New issue
Advanced search Search tips

Issue 824729 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

The Service Worker scope of a notification isn't passed along on Android N+

Project Member Reported by peter@chromium.org, Mar 22 2018

Issue description

NotificationPlatformBridge.makePendingIntent() sets it, but NotificationJobService.getJobExtrasFromIntent() doesn't copy it. Yay.

CL coming up :)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d74b2106bf299b59f0bc89279db903811292e34b

commit d74b2106bf299b59f0bc89279db903811292e34b
Author: Peter Beverloo <peter@chromium.org>
Date: Thu Mar 22 13:08:52 2018

Copy the notification's scope in the NotificationJobService

The NotificationJobService needs to copy the data stored in a
notification's PendingIntent to one that is safe to be used for starting
a background job. It did so for most data members, but not for the
scope.

Bug:  824729 
Change-Id: Ifbb7d8b22e15074545fd756a012f84f6a17b68e1
Reviewed-on: https://chromium-review.googlesource.com/975128
Commit-Queue: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545054}
[modify] https://crrev.com/d74b2106bf299b59f0bc89279db903811292e34b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java
[modify] https://crrev.com/d74b2106bf299b59f0bc89279db903811292e34b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

Comment 2 by peter@chromium.org, Mar 22 2018

Status: Fixed (was: Started)

Sign in to add a comment