Non-Regression: Weird traces of app names are seen when disabling overview mode |
|||
Issue descriptionChrome Version: 66.0.3359.48/10452.22.0 beta channel Kip, Reks, Daisy OS: Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Keep some apps open and click overview button few times and observe Actual: Weird traces of the app names are seen Expected: No such issue should be seen This is a Non-Regression issue seen from M-62 NOTE: Issue is seen on M63, M64, M65 and M67 also
,
Mar 23 2018
+mccanny Ben, to double check, should we just hide the titles for minimized windows?
,
Mar 23 2018
Good catch. I didn't mock the case with only minimized windows, but for simplicity let's apply the same rules for all minimized windows as is specced here: http://go/wm-motion/#overview-freeform I.e., don't change the position or size of minimized windows, just fade in/out the windows and title bars uniformly.
,
Mar 26 2018
re #3 For minimized windows, on entering overview are sized to their non minimized dimensions and animated to the overview dimensions. On exit, they just disappear (no animation). I guess we want to change that?
,
Mar 26 2018
Yep - minimized windows more recently used than the most recently used fullscreen window should just fade in at their overview position and size as overview blur fades in. Windows 'behind' the most recently used fullscreen window should just appear to be there in overview like their non-minimized counterparts are with Tao's updated animation. Exit is the same logic, just fading out in place of fading in.
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/855e372a61985e332a6def967957d6a3d2209ada commit 855e372a61985e332a6def967957d6a3d2209ada Author: Sammie Quon <sammiequon@google.com> Date: Fri May 04 02:03:17 2018 overview: Fade in and out minimized windows in tablet mode. Moved a common set of lines to overview_utils.cc and used the new function to fade out minimzed windows in tablet mode. Test: none Bug: 824720 , 839486 Change-Id: I4655a49d5f79db9d98786a7cef6fdbcc23ddfb9d Reviewed-on: https://chromium-review.googlesource.com/984402 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555958} [modify] https://crrev.com/855e372a61985e332a6def967957d6a3d2209ada/ash/wm/overview/overview_utils.cc [modify] https://crrev.com/855e372a61985e332a6def967957d6a3d2209ada/ash/wm/overview/overview_utils.h [modify] https://crrev.com/855e372a61985e332a6def967957d6a3d2209ada/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/855e372a61985e332a6def967957d6a3d2209ada/ash/wm/overview/window_grid.cc [modify] https://crrev.com/855e372a61985e332a6def967957d6a3d2209ada/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/855e372a61985e332a6def967957d6a3d2209ada/ash/wm/overview/window_selector_item.h
,
May 4 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by x...@chromium.org
, Mar 23 2018Status: Assigned (was: Untriaged)