Media Capabilities: mark encoding API experimental |
||||||
Issue descriptionEncoding API was mistakenly promoted stable earlier. This CL fixes this and introduces a new MediaCapabilitiesEncodingInfo runtime enabled feature marked as experimental.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9b0a873676eae273e5c167e3b3a933dd2733683 commit c9b0a873676eae273e5c167e3b3a933dd2733683 Author: François Beaufort <beaufort.francois@gmail.com> Date: Thu Mar 22 10:37:55 2018 Media Capabilities: mark encoding API experimental Encoding API was mistakenly promoted stable earlier. This CL fixes this and introduces a new MediaCapabilitiesEncodingInfo runtime enabled feature marked as experimental. Bug: 824708 Change-Id: I8f06982471ee544919fe427f782b8d8ccf21f7b5 Reviewed-on: https://chromium-review.googlesource.com/970463 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545036} [modify] https://crrev.com/c9b0a873676eae273e5c167e3b3a933dd2733683/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/c9b0a873676eae273e5c167e3b3a933dd2733683/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl [modify] https://crrev.com/c9b0a873676eae273e5c167e3b3a933dd2733683/third_party/WebKit/Source/platform/runtime_enabled_features.json5
,
Mar 22 2018
,
Mar 22 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
Let's wait until this lands in canary first.
,
Mar 27 2018
can you please confirm how this looks in canary?
,
Mar 28 2018
It looks great in Canary: decodingInfo is exposed while encodingInfo is not. See DevTools screenshot attached.
,
Mar 28 2018
Approving merge to M66. Branch:3359
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/366c4895343668b87f58017d6803764b56f6b5af commit 366c4895343668b87f58017d6803764b56f6b5af Author: François Beaufort <beaufort.francois@gmail.com> Date: Wed Mar 28 18:41:04 2018 Media Capabilities: mark encoding API experimental Encoding API was mistakenly promoted stable earlier. This CL fixes this and introduces a new MediaCapabilitiesEncodingInfo runtime enabled feature marked as experimental. Bug: 824708 Change-Id: I8f06982471ee544919fe427f782b8d8ccf21f7b5 Reviewed-on: https://chromium-review.googlesource.com/970463 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#545036}(cherry picked from commit c9b0a873676eae273e5c167e3b3a933dd2733683) Reviewed-on: https://chromium-review.googlesource.com/984792 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3359@{#487} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/366c4895343668b87f58017d6803764b56f6b5af/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/366c4895343668b87f58017d6803764b56f6b5af/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl [modify] https://crrev.com/366c4895343668b87f58017d6803764b56f6b5af/third_party/WebKit/Source/platform/runtime_enabled_features.json5
,
Mar 28 2018
Thanks François! :)
,
Nov 21
François, what makes encodingInfo() experimental? Is there something missing?
,
Nov 21
Intent to ship was only for the decodingInfo part, not the encodingInfo. This is why this API is still experimental. You'd need a proper and separate Intent to Ship for encodingInfo. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mlamouri@chromium.org
, Mar 22 2018