New issue
Advanced search Search tips

Issue 824708 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 690364



Sign in to add a comment

Media Capabilities: mark encoding API experimental

Project Member Reported by fbeaufort@chromium.org, Mar 22 2018

Issue description

Encoding API was mistakenly promoted stable earlier. This CL fixes this and introduces a new MediaCapabilitiesEncodingInfo runtime enabled feature marked as experimental.
 
Labels: -Pri-3 M-66 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9b0a873676eae273e5c167e3b3a933dd2733683

commit c9b0a873676eae273e5c167e3b3a933dd2733683
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Thu Mar 22 10:37:55 2018

Media Capabilities: mark encoding API experimental

Encoding API was mistakenly promoted stable earlier. This CL fixes this
and introduces a new MediaCapabilitiesEncodingInfo runtime enabled
feature marked as experimental.

Bug:  824708 
Change-Id: I8f06982471ee544919fe427f782b8d8ccf21f7b5
Reviewed-on: https://chromium-review.googlesource.com/970463
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545036}
[modify] https://crrev.com/c9b0a873676eae273e5c167e3b3a933dd2733683/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c9b0a873676eae273e5c167e3b3a933dd2733683/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl
[modify] https://crrev.com/c9b0a873676eae273e5c167e3b3a933dd2733683/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Labels: Merge-Request-66
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 22 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Let's wait until this lands in canary first. 
can you please confirm how this looks in canary?
It looks great in Canary: decodingInfo is exposed while encodingInfo is not.
See DevTools screenshot attached.
Screen Shot 2018-03-28 at 10.32.10 AM.png
99 KB View Download
Labels: -Merge-Review-66 Merge-Approved-66
Approving merge to M66. Branch:3359
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 28 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/366c4895343668b87f58017d6803764b56f6b5af

commit 366c4895343668b87f58017d6803764b56f6b5af
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Wed Mar 28 18:41:04 2018

Media Capabilities: mark encoding API experimental

Encoding API was mistakenly promoted stable earlier. This CL fixes this
and introduces a new MediaCapabilitiesEncodingInfo runtime enabled
feature marked as experimental.

Bug:  824708 
Change-Id: I8f06982471ee544919fe427f782b8d8ccf21f7b5
Reviewed-on: https://chromium-review.googlesource.com/970463
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#545036}(cherry picked from commit c9b0a873676eae273e5c167e3b3a933dd2733683)
Reviewed-on: https://chromium-review.googlesource.com/984792
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/branch-heads/3359@{#487}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/366c4895343668b87f58017d6803764b56f6b5af/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/366c4895343668b87f58017d6803764b56f6b5af/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl
[modify] https://crrev.com/366c4895343668b87f58017d6803764b56f6b5af/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Status: Fixed (was: Started)
Thanks François! :)
François, what makes encodingInfo() experimental? Is there something missing?
Intent to ship was only for the decodingInfo part, not the encodingInfo. This is why this API is still experimental. You'd need a proper and separate Intent to Ship for encodingInfo.

Sign in to add a comment