New issue
Advanced search Search tips

Issue 824704 link

Starred by 2 users
Status: Fixed
Owner:
odejesush@chromium.org
Closed: Apr 2018
Cc:
odejesush@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 719826
issue 719827



Sign in to add a comment

Use of DeviceUUIDs in FakeBluetooth causes blocklisted services tests to crash on Win 7

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Mar 22 2018 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of cfroussios@chromium.org

...... too many results, data snipped.... and 40 other(s) in webkit_layout_tests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Comment 1 by cfroussios@chromium.org, Mar 22 2018 

* external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
* external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
* external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
* external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html

have been failing since https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/66986
I don't see an obvious culprit in the blamelist.

Comment 2 by cfroussios@chromium.org, Mar 22 2018 

I will revert https://chromium-review.googlesource.com/c/chromium/src/+/958337, because it's the only CL that touched bluetooth.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/105a98d1bc948e5bd62a978d58d70c1b465c28c4

commit 105a98d1bc948e5bd62a978d58d70c1b465c28c4
Author: Christos Froussios <cfroussios@chromium.org>
Date: Thu Mar 22 12:00:14 2018

Revert "bluetooth: Use DeviceUUID in FakePeripheral"

This reverts commit 20d09354e647316c4c51ab94ab63c18024f791dc.

Reason for revert: Suspected of breaking
* external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
* external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
* external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
* external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html

Original change's description:
> bluetooth: Use DeviceUUID in FakePeripheral
> 
> This change refactors FakePeripheral to use the built-in DeviceUUIDs
> helper class in BluetoothDevice to handle the UUIDs for a device.
> 
> BUG=719826
> 
> Change-Id: I9c60f00912aca706f16f402031483711f6f3ae89
> Reviewed-on: https://chromium-review.googlesource.com/958337
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Conley Owens <cco3@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544235}

TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 719826,  824704 
Change-Id: I4543474f7412f954fe062c06d05a458cdf6d6447
Reviewed-on: https://chromium-review.googlesource.com/975123
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545043}
[modify] https://crrev.com/105a98d1bc948e5bd62a978d58d70c1b465c28c4/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/105a98d1bc948e5bd62a978d58d70c1b465c28c4/device/bluetooth/test/fake_peripheral.cc
[modify] https://crrev.com/105a98d1bc948e5bd62a978d58d70c1b465c28c4/device/bluetooth/test/fake_peripheral.h

Comment 4 by cfroussios@chromium.org, Mar 22 2018

Labels: -Sheriff-Chromium
Owner: odejesush@chromium.org
Status: Assigned (was: Available)
Reverting seems to have fixed it.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7

commit 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7
Author: Ovidio Henriquez <odejesush@chromium.org>
Date: Wed Mar 28 16:07:28 2018

bluetooth: FakeBluetoothChooser impl.

Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.

This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.

BUG=719827,719826, 824704 

Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3
Reviewed-on: https://chromium-review.googlesource.com/962983
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546509}
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/content/shell/browser/layout_test/fake_bluetooth_chooser.cc
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/content/shell/browser/layout_test/fake_bluetooth_chooser.h
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/content/shell/common/layout_test/fake_bluetooth_chooser.mojom
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/device/bluetooth/test/fake_peripheral.cc
[delete] https://crrev.com/796a52c1d07285b09a47bad7049ecaafcfb40aa0/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html
[delete] https://crrev.com/796a52c1d07285b09a47bad7049ecaafcfb40aa0/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
[modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42624492cd5e80855f1dd3a5a8146b258def2c2a

commit 42624492cd5e80855f1dd3a5a8146b258def2c2a
Author: François Doray <fdoray@chromium.org>
Date: Wed Mar 28 19:48:22 2018

Revert "bluetooth: FakeBluetoothChooser impl."

This reverts commit 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7.

Reason for revert:  https://crbug.com/826787 

Original change's description:
> bluetooth: FakeBluetoothChooser impl.
>
> Implements the interfaces that FakeBluetoothChooser overrides. The
> mojom::FakeBluetoothChooser overrides are implemented by running
> |event_handler_| with the appropriate arguments. The BluetoothChooser
> overrides do nothing at the moment, since the base class is only meant
> to update the chooser user interface.
>
> This change also begins to partially convert a Bluetooth chooser test to test
> the interface and deletes the temporary tests that were created to test this
> API.
>
> BUG=719827,719826, 824704 
>
> Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3
> Reviewed-on: https://chromium-review.googlesource.com/962983
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Conley Owens <cco3@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546509}

TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org

Change-Id: I0597151ec5878d41ac631b72296203bc99b1f2c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 719827, 719826,  824704 ,  826787 
Reviewed-on: https://chromium-review.googlesource.com/984299
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546572}
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/content/shell/browser/layout_test/fake_bluetooth_chooser.cc
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/content/shell/browser/layout_test/fake_bluetooth_chooser.h
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/content/shell/common/layout_test/fake_bluetooth_chooser.mojom
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/device/bluetooth/test/fake_peripheral.cc
[add] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html
[add] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
[modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a337f19713e049cd42969b0c909c59aff4146cd

commit 6a337f19713e049cd42969b0c909c59aff4146cd
Author: Ovidio Henriquez <odejesush@chromium.org>
Date: Thu Mar 29 05:16:26 2018

bluetooth: FakeBluetoothChooser impl.

Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.

This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.

This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
reverted the original change. The original change caused the
new-scan-device-added.html test to fail because of a Mojo validation error
resulting from not updating the
third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
file needed by the test.

Bug: 719827, 719826,  824704 ,  826787 
Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
Reviewed-on: https://chromium-review.googlesource.com/985195
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546729}
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/content/shell/browser/layout_test/fake_bluetooth_chooser.cc
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/content/shell/browser/layout_test/fake_bluetooth_chooser.h
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/content/shell/common/layout_test/fake_bluetooth_chooser.mojom
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/device/bluetooth/test/fake_peripheral.cc
[delete] https://crrev.com/fad0f0ae8508c3df9a7eed21de48065117c7a753/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html
[delete] https://crrev.com/fad0f0ae8508c3df9a7eed21de48065117c7a753/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
[modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d04a1e5256a9fdd78f40cbdb73355408614e14f3

commit d04a1e5256a9fdd78f40cbdb73355408614e14f3
Author: François Doray <fdoray@chromium.org>
Date: Thu Mar 29 16:27:57 2018

Revert "bluetooth: FakeBluetoothChooser impl."

This reverts commit 6a337f19713e049cd42969b0c909c59aff4146cd.

Reason for revert:  https://crbug.com/824704 

These tests are failing:

external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.https.html
external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html

Original change's description:
> bluetooth: FakeBluetoothChooser impl.
> 
> Implements the interfaces that FakeBluetoothChooser overrides. The
> mojom::FakeBluetoothChooser overrides are implemented by running
> |event_handler_| with the appropriate arguments. The BluetoothChooser
> overrides do nothing at the moment, since the base class is only meant
> to update the chooser user interface.
> 
> This change also begins to partially convert a Bluetooth chooser test to test
> the interface and deletes the temporary tests that were created to test this
> API.
> 
> This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
> reverted the original change. The original change caused the
> new-scan-device-added.html test to fail because of a Mojo validation error
> resulting from not updating the
> third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
> file needed by the test.
> 
> Bug: 719827, 719826,  824704 ,  826787 
> Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
> Reviewed-on: https://chromium-review.googlesource.com/985195
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546729}

TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org

Change-Id: Ie2ef2af1ae74e8dd5ca01441027adaa59e6e0c0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 719827, 719826,  824704 ,  826787 
Reviewed-on: https://chromium-review.googlesource.com/986592
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546851}
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/content/shell/browser/layout_test/fake_bluetooth_chooser.cc
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/content/shell/browser/layout_test/fake_bluetooth_chooser.h
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/content/shell/common/layout_test/fake_bluetooth_chooser.mojom
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/device/bluetooth/test/fake_peripheral.cc
[add] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html
[add] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
[modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js

Comment 9 by odejesush@chromium.org, Apr 6 2018

Cc: odejesush@chromium.org fdoray@chromium.org
 Issue 826787  has been merged into this issue.

Comment 10 by odejesush@chromium.org, Apr 6 2018 

 Issue 827088  has been merged into this issue.

Comment 11 by odejesush@chromium.org, Apr 6 2018

Blocking: 719826 719827
Components: Blink>Bluetooth
Labels: -Pri-2 OS-Windows Pri-3 Type-Bug
Summary: Use of DeviceUUIDs in FakeBluetooth causes blocklisted services tests to crash on Win 7 (was: ...... too many results, data snipped.... and 40 other(s) in webkit_layout_tests failing on chromium.win/Win7 Tests (dbg)(1))

Comment 12 by fdoray@chromium.org, Apr 6 2018

Cc: -fdoray@chromium.org

Comment 13 by odejesush@chromium.org, Apr 12 2018

Cc: -cfroussios@chromium.org
Status: Fixed (was: Assigned)
Reverting the change fixes the failing tests, so I will close the issue.
►

Sign in to add a comment