New issue
Advanced search Search tips

Issue 824691 link

Starred by 1 user
Status: Fixed
Owner:
pfeldman@chromium.org
Closed: Apr 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Red highlight is not seen for empty text field on dev tools window.

Reported by db...@etouch.net, Mar 22 2018 
Chrome Version: 67.0.3378.0 Revision 05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2-refs/heads/master@{#544931}(32/64 bit)
OS Windows(7,8,8.1,10)

What steps will reproduce the problem?
(1) Launch chrome, open dev tools window and click on 'Toggle device toolbar' icon.
(2) Clcik on Width text box and clear text, then press Tab key and observe.

Actual: Red highlight is not seen for empty text field on dev tools.

Expected: Red highlight should seen for empty text field on dev tools.

This is a regression issue, broken in 'M67', will soon update the other info:

Comment 1 by db...@etouch.net, Mar 22 2018

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67 OS-Linux OS-Mac
Owner: pfeldman@chromium.org
Status: Assigned (was: Unconfirmed)
Manual bisect range:
Good Build:67.0.3377.0(Revision:544611 )
Bad Build: 67.0.3378.0(Revision: 544931 )

You are probably looking for a change made after 544617 (known good), but no later than 544618 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/af71563d3c61e712f355f6b73d5b589ab9d9ed97..84798c860d86bd5b7dd22fe75df83b5280dbf39f

Suspect: https://chromium.googlesource.com/chromium/src/+/84798c860d86bd5b7dd22fe75df83b5280dbf39f

Note: Issue is also seen on Mac(10.12.6,10.13.1,10.13.4) and Linux(14.04 LTS) OS.
Actual_Result.mp4
359 KB View Download
Expected_Result.mp4
402 KB View Download

Comment 2 by ligim...@chromium.org, Mar 22 2018

Labels: ReleaseBlock-Stable
RBS, since its a recent regression.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03ad1ac972abf77263f96c57cb197b193c537e76

commit 03ad1ac972abf77263f96c57cb197b193c537e76
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Mon Apr 02 22:33:46 2018

DevTools: Red highlight is not seen for empty text field on dev tools window.

Bug:  824691 
Change-Id: I78c4e15d956b858b385464e4265143ddfd1651ed
Reviewed-on: https://chromium-review.googlesource.com/990481
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547541}
[modify] https://crrev.com/03ad1ac972abf77263f96c57cb197b193c537e76/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css

Comment 4 by db...@etouch.net, Apr 3 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3387.0
Just to update:

Above issue is fixed on Windows(7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.4) and Linux(14.04 LTS) OS using latest canary 67.0.3387.0 and working as intented.

Kindly refer attached video for the same.
Fix_issue.mp4
539 KB View Download

Comment 5 by pfeldman@chromium.org, Apr 17 2018

Labels: -ReleaseBlock-Stable
Status: Fixed (was: Assigned)
Project Member

Comment 6 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Apr 17 2018

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.

Comment 7 by gov...@chromium.org, Apr 17 2018

Labels: -Merge-TBD
CL listed at #3 is already in M67 branch.
►

Sign in to add a comment