New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824679 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

"javac: invalid flag: -Xep:ParameterNotNullable:ERROR" on a WebRTC target

Project Member Reported by oprypin@chromium.org, Mar 22 2018

Issue description

This CL landed in WebRTC and works well
https://webrtc-review.googlesource.com/c/src/+/51960

However, when trying to roll it into Chromium
https://chromium-review.googlesource.com/c/chromium/src/+/973886
there is a strange failure on some of the trybots

https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.android%2Fandroid_clang_dbg_recipe%2F461744%2F%2B%2Frecipes%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout

FAILED: gen/third_party/webrtc/rtc_base/base_java.javac.jar gen/third_party/webrtc/rtc_base/base_java.javac.jar.md5.stamp gen/third_party/webrtc/rtc_base/base_java.javac.jar.info 
python ../../build/android/gyp/javac.py --depfile=gen/third_party/webrtc/rtc_base/base_java__compile_java.d --jar-path=gen/third_party/webrtc/rtc_base/base_java.javac.jar --java-srcjars=\[\] --java-srcjars=@FileArg\(gen/third_party/webrtc/rtc_base/base_java.build_config:javac:srcjars\) --java-version=1.8 --full-classpath=@FileArg\(gen/third_party/webrtc/rtc_base/base_java.build_config:deps_info:javac_full_classpath\) --interface-classpath=@FileArg\(gen/third_party/webrtc/rtc_base/base_java.build_config:deps_info:javac_full_interface_classpath\) --processorpath=@FileArg\(gen/third_party/webrtc/rtc_base/base_java.build_config:javac:processor_classpath\) --processors=@FileArg\(gen/third_party/webrtc/rtc_base/base_java.build_config:javac:processor_classes\) --bootclasspath=lib.java/android.interface.jar @gen/third_party/webrtc/rtc_base/base_java.sources --javac-arg=-Werror --javac-arg=-Xep:ParameterNotNullable:ERROR --javac-arg=-Xep:FieldMissingNullable:ERROR --javac-arg=-Xep:ReturnMissingNullable:ERROR
Traceback (most recent call last):
  File "../../build/android/gyp/javac.py", line 629, in <module>
    sys.exit(main(sys.argv[1:]))
  File "../../build/android/gyp/javac.py", line 625, in main
    pass_changes=True)
  File "/b/c/b/android_clang_dbg_recipe/src/build/android/gyp/util/build_utils.py", line 606, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/b/c/b/android_clang_dbg_recipe/src/build/android/gyp/util/md5_check.py", line 87, in CallAndRecordIfStale
    function(*args)
  File "/b/c/b/android_clang_dbg_recipe/src/build/android/gyp/util/build_utils.py", line 589, in on_stale_md5
    function(*args)
  File "../../build/android/gyp/javac.py", line 618, in <lambda>
    classpath_inputs, classpath),
  File "../../build/android/gyp/javac.py", line 388, in _OnStaleMd5
    attempt_build()
  File "../../build/android/gyp/javac.py", line 386, in <lambda>
    stderr_filter=ProcessJavacOutput)
  File "/b/c/b/android_clang_dbg_recipe/src/build/android/gyp/util/build_utils.py", line 190, in CheckOutput
    raise CalledProcessError(cwd, args, stdout + stderr)
util.build_utils.CalledProcessError: Command failed: ( cd /b/c/b/android_clang_dbg_recipe/src/out/Debug; /usr/bin/javac -g -encoding UTF-8 -sourcepath : -source 1.8 -target 1.8 -XDignore.symbol.file -bootclasspath lib.java/android.interface.jar:/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/rt.jar -Werror -Xep:ParameterNotNullable:ERROR -Xep:FieldMissingNullable:ERROR -Xep:ReturnMissingNullable:ERROR -d /tmp/tmpsvVMR9/classes -classpath lib.java/third_party/bazel/desugar/Desugar-runtime.interface.jar:lib.java/build/android/buildhooks/build_hooks_java.interface.jar:lib.java/third_party/jsr-305/jsr_305_javalib.interface.jar @/tmp/tmpsvVMR9/files_list.txt )
javac: invalid flag: -Xep:ParameterNotNullable:ERROR
Usage: javac <options> <source files>
use -help for a list of possible options


To reproduce:

cd chromium/src
git cl patch https://chromium-review.googlesource.com/c/chromium/src/+/973886
gclient sync
gn gen '--args=ffmpeg_branding="Chrome" is_asan=true is_clang=true is_component_build=true is_debug=true proprietary_codecs=true strip_absolute_paths_from
_debug_symbols=true symbol_level=0 target_os="android"' out/android-debug
ninja -C out/android-debug third_party/webrtc/rtc_base:base_java


When compiling the same target with the same flags (except componentbuild) in WebRTC it works fine.

We can work around this:
https://webrtc-review.googlesource.com/c/src/+/64040
but we need to find out why this happens
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a09993d1478c1705836028e1374dbf464544a432

commit a09993d1478c1705836028e1374dbf464544a432
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Mar 22 09:47:53 2018

Skip nullable check when building in Chromium

Otherwise it fails when building 'all':
"javac: invalid flag: -Xep:ParameterNotNullable:ERROR"

No-Try: True
Bug:  chromium:824679 ,  webrtc:8881 
Change-Id: Ib2e5ca1257bfe3c3d0f0ecfce2d5ac2bd165720b
Reviewed-on: https://webrtc-review.googlesource.com/64040
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22556}
[modify] https://crrev.com/a09993d1478c1705836028e1374dbf464544a432/rtc_base/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e773cfb285e3687410f592886c2400327d5d944d

commit e773cfb285e3687410f592886c2400327d5d944d
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Mar 22 14:00:39 2018

Roll src/third_party/webrtc/ 3dc0125cf..b3179c75e (45 commits)

https://webrtc.googlesource.com/src.git/+log/3dc0125cf7e8..b3179c75ed40

$ git log 3dc0125cf..b3179c75e --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:824111,chromium:824679,chromium:none,chromium:None,chromium:None,chromium:None,chromium:824111,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Icaa35e74c476b297d3c935b54e86d9b172d7703e
Reviewed-on: https://chromium-review.googlesource.com/975348
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545059}
[modify] https://crrev.com/e773cfb285e3687410f592886c2400327d5d944d/DEPS

Sign in to add a comment