New issue
Advanced search Search tips

Issue 824627 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Results box floats upwards covering omnibox\tabs as I type in the omnibox

Reported by jtcgiant...@gmail.com, Mar 22 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.45 Safari/537.36

Steps to reproduce the problem:
1. Type anything in the omnibox
2. 
3. 

What is the expected behavior?
Results box to stay stationary

What went wrong?
This issue first started when I was upgraded to v66 beta. As I type anything in the omnibox the floats start to float upwards covering the ominibox and my tabs.

Here is a gif of it in action - https://imgur.com/lcsD9mX

This happens every time. 

Did this work before? Yes 65.0.3325.125 beta

Chrome version: 66.0.3359.45  Channel: beta
OS Version: 10.0
Flash Version:
 
Labels: Needs-Bisect Needs-Triage-M66
Cc: susan.boorgula@chromium.org
Labels: Triaged-ET Needs-Feedback
jtcgiants56@ Thanks for the issue.

Tested this issue on Windows 10 and Mac OS 10.12.6 on the reported version 66.0.3359.45 and the latest Canary and unable to reproduce the issue by following the below steps.

1. Launched Chrome version 65.0.3325.125 and upgraded to 66.0.3359.45 build.
2. typed in the omnibox and could not observe any floating on the omnibox.
3. Tried on a build without upgrading and couldn't observe any issues.
Attached is the screen cast for reference.

Request you to retry the issue on a new chrome profile without any flags/extensions and update the thread with the observations.

Thanks..
824627.mp4
1.5 MB View Download
Hello, I've created a new profile with no extensions and disabled all flags. I experience the same behavior. 
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 23 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: UI>Browser>Omnibox
Labels: Needs-Feedback
jtcgiants56@ Thanks for the feedback.

Re-tested this issue on Windows 10, Mac OS 10.12.6 and Ubuntu 14.04 on the reported version 66.0.3359.45 and the latest Canary 67.0.3379.0 and unable to reproduce the issue.
Can observe no issues while typing on the omnibox.

Adding 'UI>Browser>Omnibox' component and requesting someone from that team to please look into this issue and help in further triaging.

Thanks..


I would suspect something relating to non-integral DSFs.  Reporter, what's your system UI zoom/scale factor set to?
I have a custom DPI scaling of 115% in windows 10. Turning that off the issue stops. Turning it back on the issue starts again.
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 26 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 -Needs-Bisect FoundIn-66 FoundIn-67 M-66 Target-67 Target-66 RegressedIn-66 hasbisect Pri-1
Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)
jtcgiants56@ Thanks for the feedback.

Able to reproduce this issue on Windows 10 on the latest Canary 67.0.3379.0 and Beta 66.0.3359.45 as per comment #7.
While custom setting the scaling to 115% on Windows, can observe that Chrome omnibox is floating while typing.

Note: Issue is not observed on Mac OS 10.12.6 and Ubuntu 14.04 by launching chrome with --device-scale-factor=1.5 and even tried changing the system scaling and no issue is observed.

Bisect Information:
===================
Good Build: 66.0.3347.0 (Revision - 536620)
Bad Build : 66.0.3348.0 (Revision - 536934)

On executing the Chromium bisect script, below is the Changelog URL:

https://chromium.googlesource.com/chromium/src/+log/001696336f3e1333dbb085aed18f78236d8d8c5e..d3ccb60b66b07a34e99a77899acce76a860d867a

From the above Changelog, suspecting the below change:
Reviewed-on: https://chromium-review.googlesource.com/912851

tapted@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Adding ReleaseBlock-Stable for M-66 as this is a recent regression. Please feel free to remove it if it is not applicable.

Thanks.
Labels: ReleaseBlock-Stable
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/981970
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43fdbea70216927d5b53a063ddbf81e6dbee373c

commit 43fdbea70216927d5b53a063ddbf81e6dbee373c
Author: Trent Apted <tapted@chromium.org>
Date: Wed Mar 28 01:14:24 2018

Fix omnibox dropdown bounds setting on non-integral scale factors

Care needs to be taken when querying the current Widget bounds since
it may be rounded up from a prior call to SetBounds() on screens with
non-integral scale factors.

To fix, never ask the Widget for its current bounds. Instead, just
assume the last *set* bounds is where the shrink animation should start
from.

Bug:  824627 ,  629363 
Change-Id: I6914f5a779ff57f9fa1c10aefcd04579784d73ca
Reviewed-on: https://chromium-review.googlesource.com/981970
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546354}
[modify] https://crrev.com/43fdbea70216927d5b53a063ddbf81e6dbee373c/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

The 3382 canary branched at r546346 so this will need to wait another day to verify.
Labels: TE-Verified-M67 TE-Verified-67.0.3383.0
Able to reproduce this issue on Windows 10 on the reported version 66.0.3359.45 and the issue is fixed on the latest Canary 67.0.3383.0.

After custom setting the scaling to 115% on Windows, cannot observe any floating while typing in the omnibox.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
824627-M67.mp4
1.4 MB View Download
Labels: Merge-Request-66
Thanks for verifying! Requesting merge of r546354 to m66.
Project Member

Comment 16 by sheriffbot@chromium.org, Mar 29 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Approved branch:3359
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 29 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bc9cf9d0e9f6d22768a8c60fb8ff29b9fa87551

commit 8bc9cf9d0e9f6d22768a8c60fb8ff29b9fa87551
Author: Trent Apted <tapted@chromium.org>
Date: Thu Mar 29 21:06:32 2018

[merge-m66] Fix omnibox dropdown bounds setting on non-integral scale factors

Care needs to be taken when querying the current Widget bounds since
it may be rounded up from a prior call to SetBounds() on screens with
non-integral scale factors.

To fix, never ask the Widget for its current bounds. Instead, just
assume the last *set* bounds is where the shrink animation should start
from.

Bug:  824627 ,  629363 
Change-Id: I6914f5a779ff57f9fa1c10aefcd04579784d73ca
Reviewed-on: https://chromium-review.googlesource.com/981970
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#546354}(cherry picked from commit 43fdbea70216927d5b53a063ddbf81e6dbee373c)
Reviewed-on: https://chromium-review.googlesource.com/986952
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#505}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/8bc9cf9d0e9f6d22768a8c60fb8ff29b9fa87551/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M66 TE-Verified-66.0.3359.81
Able to reproduce this issue on Windows 10 on the reported version 66.0.3359.45 and the issue is fixed on the latest Beta 66.0.3359.81.

After custom setting the scaling to 115% on Windows, cannot observe any floating while typing in the omnibox.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
824627-M66.mp4
1.0 MB View Download
Confirm issue fixed as well on 66.0.3359.81.

Sign in to add a comment