New issue
Advanced search Search tips

Issue 824624 link

Starred by 0 users
Status: Fixed
Owner:
joelhockey@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CrOS FilesApp closure compiler doesn't seem to run on all files

Project Member Reported by joelhockey@chromium.org, Mar 22 2018 
Investigate why closure compiler did not pick up mismatch function call for MockVolumeManager to call VolumeInfoImpl ctor in
https://chromium-review.googlesource.com/c/chromium/src/+/950622

I suspect that not all files are being fed into the closure compiler or it should have picked this up.

Comment 1 by joelhockey@chromium.org, Mar 26 2018 

In progress CL at http://crosreview.com/979747

This looks to be a medium chunk of work which trickles out to a number of other files.

Comment 2 by joelhockey@chromium.org, Mar 26 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4d74b415e75f0d7628269b4a1d289ef2cc188ab

commit d4d74b415e75f0d7628269b4a1d289ef2cc188ab
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Mar 28 05:35:44 2018

Run closure compiler on MockVolumeManager

Bug:  824624 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7cbc48e05ad179eb554f3ac5df3941b723afcf5e
Reviewed-on: https://chromium-review.googlesource.com/979747
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546419}
[modify] https://crrev.com/d4d74b415e75f0d7628269b4a1d289ef2cc188ab/ui/file_manager/file_manager/background/js/compiled_resources2.gyp
[modify] https://crrev.com/d4d74b415e75f0d7628269b4a1d289ef2cc188ab/ui/file_manager/file_manager/background/js/mock_volume_manager.js
[modify] https://crrev.com/d4d74b415e75f0d7628269b4a1d289ef2cc188ab/ui/file_manager/file_manager/background/js/volume_info_impl.js
[modify] https://crrev.com/d4d74b415e75f0d7628269b4a1d289ef2cc188ab/ui/file_manager/file_manager/common/js/compiled_resources2.gyp
[modify] https://crrev.com/d4d74b415e75f0d7628269b4a1d289ef2cc188ab/ui/file_manager/file_manager/common/js/mock_entry.js
[modify] https://crrev.com/d4d74b415e75f0d7628269b4a1d289ef2cc188ab/ui/file_manager/file_manager/common/js/volume_manager_common.js

Comment 4 by joelhockey@chromium.org, Mar 28 2018

Status: Fixed (was: Started)
►

Sign in to add a comment