New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824610 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

"MediaRouterIntegrationBrowserTest.Dialog_Basic" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 22 2018

Issue description

"MediaRouterIntegrationBrowserTest.Dialog_Basic" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5NZWRpYVJvdXRlckludGVncmF0aW9uQnJvd3NlclRlc3QuRGlhbG9nX0Jhc2ljDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
The test is flaky on MacOS. I will disable it on https://chromium-review.googlesource.com/c/chromium/src/+/975304
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/075859bd8353bf5f74530491b450feaa9082a21d

commit 075859bd8353bf5f74530491b450feaa9082a21d
Author: Christos Froussios <cfroussios@chromium.org>
Date: Thu Mar 22 12:36:18 2018

Disable MediaRouterIntegrationBrowserTest.Dialog_Basic on MacOS

It was detected to be flaky

TBR=mfoltz@chromium.org

Bug:  824610 
Change-Id: I958b7ecf83d01eb396638461271262599286fb7a
Reviewed-on: https://chromium-review.googlesource.com/975304
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545046}
[modify] https://crrev.com/075859bd8353bf5f74530491b450feaa9082a21d/chrome/test/media_router/media_router_integration_ui_browsertest.cc

Cc: mfo...@chromium.org
Labels: -Sheriff-Chromium OS-Mac
Owner: apaci...@chromium.org
+apacible, +mfoltz
Adding some owners of the test. Please help triage or investigate. 
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8756aa5e6ef8a5ff544638d295001cb0a338782d

commit 8756aa5e6ef8a5ff544638d295001cb0a338782d
Author: Fady Samuel <fsamuel@chromium.org>
Date: Thu Mar 22 12:49:10 2018

Revert "Disable MediaRouterIntegrationBrowserTest.Dialog_Basic on MacOS"

This reverts commit 075859bd8353bf5f74530491b450feaa9082a21d.

Reason for revert: The offending patch has been reverted. I'm re-enabling this.

Original change's description:
> Disable MediaRouterIntegrationBrowserTest.Dialog_Basic on MacOS
> 
> It was detected to be flaky
> 
> TBR=mfoltz@chromium.org
> 
> Bug:  824610 
> Change-Id: I958b7ecf83d01eb396638461271262599286fb7a
> Reviewed-on: https://chromium-review.googlesource.com/975304
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545046}

TBR=cfroussios@chromium.org

Change-Id: Ic791f98fcb60d7ed03636e3c45bcddb816f6b0bc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  824610 
Reviewed-on: https://chromium-review.googlesource.com/975441
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545047}
[modify] https://crrev.com/8756aa5e6ef8a5ff544638d295001cb0a338782d/chrome/test/media_router/media_router_integration_ui_browsertest.cc

Status: Assigned (was: Untriaged)
Mac triage: marking assigned.

Comment 6 by mfo...@chromium.org, Mar 22 2018

Status: Fixed (was: Assigned)
This test has been passing on recent build runs.  Closing.

Sign in to add a comment