New issue
Advanced search Search tips

Issue 824607 link

Starred by 1 user
Status: Fixed
Owner:
joelhockey@chromium.org
Closed: Mar 2018
Cc:
weifangsun@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 397213



Sign in to add a comment

Add 2 UMAs to record how users interact with the Files app

Project Member Reported by sashab@chromium.org, Mar 22 2018 
Create 2 UMAs in actions.xml:
'FileBrowser.ClickBreadcrumbs'
'FileBrowser.ExpandThumbnail'

Add the following using recordUserAction:
FileBrowser.ClickBreadcrumbs - Return to a parent directory using the breadcrumbs in the file selection
FileBrowser.ExpandThumbnail - View a zoomed thumbnail by hovering over the icon in the bottom bar

For an idea of how to implement, see the existing FileBrowser.FolderShortcut.Add/FileBrowser.FolderShortcut.Navigate/FileBrowser.FolderShortcut.Remove which monitors interactions with folder shortcuts.

The other available metrics methods are in metrics_base.js: https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/common/js/metrics_base.js?type=cs&sq=package:chromium

Comment 1 by joelhockey@chromium.org, Mar 23 2018

Cc: weifangsun@chromium.org
Status: Started (was: Assigned)
weifangsun@ I've done the ClickBreadcrumbs, but I don't understand the ExpandThumbnail.  I don't see a 'bottom bar' to hover over.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5be4056663ac899a2321f05eebe078607e9c8e6b

commit 5be4056663ac899a2321f05eebe078607e9c8e6b
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Mar 26 08:43:13 2018

CrOS FileManager UMA ClickBreadCrumbs

Added ClickBreadcrumbs user action for click in breadcrumb.

Fixed handling of MockFileSystem root to always include trailing slash.
The root dir is referenced in the breadcrumb and causes errors
in tests  with inconsistency of trailing slash.



Bug:  824607 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ff72f4d2542c25f87fd495bdb088d0d3315424f
Reviewed-on: https://chromium-review.googlesource.com/977381
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545740}
[modify] https://crrev.com/5be4056663ac899a2321f05eebe078607e9c8e6b/tools/metrics/actions/actions.xml
[modify] https://crrev.com/5be4056663ac899a2321f05eebe078607e9c8e6b/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[modify] https://crrev.com/5be4056663ac899a2321f05eebe078607e9c8e6b/ui/file_manager/file_manager/foreground/js/ui/location_line.js
[modify] https://crrev.com/5be4056663ac899a2321f05eebe078607e9c8e6b/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js
[add] https://crrev.com/5be4056663ac899a2321f05eebe078607e9c8e6b/ui/file_manager/file_manager/test/uma.js

Comment 3 by weifangsun@chromium.org, Mar 26 2018 

Thanks joelhockey@! I took a look and I don't think that stat is applicable anymore. Updated the UMA doc to reflect this.

Comment 4 by joelhockey@chromium.org, Mar 26 2018

Status: Fixed (was: Started)
►

Sign in to add a comment