New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824602 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Missing unit test for pending download improvement feature flag

Project Member Reported by carlosk@chromium.org, Mar 22 2018

Issue description

This new feature flag was introduced but it is missing the associated unit test. These tests live in:
components/offline_pages/core/offline_page_feature_unittest.cc

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2cf13facd7cb0e3d8ebe15c3bec8bea12684d43

commit e2cf13facd7cb0e3d8ebe15c3bec8bea12684d43
Author: Candice Sy <cmsy@google.com>
Date: Sat Mar 24 00:48:50 2018

Add unit test for descriptive pending status feature flag

Bug:  824602 
Change-Id: I1aa2c7c43ec1e6afc343a239c30846258a231644
Reviewed-on: https://chromium-review.googlesource.com/978545
Commit-Queue: Candice Sy <cmsy@google.com>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545652}
[modify] https://crrev.com/e2cf13facd7cb0e3d8ebe15c3bec8bea12684d43/components/offline_pages/core/offline_page_feature_unittest.cc

Comment 2 by cmsy@google.com, Mar 29 2018

Status: Fixed (was: Assigned)

Sign in to add a comment