New issue
Advanced search Search tips

Issue 824582 link

Starred by 1 user
Status: Fixed
Owner:
dgarr...@chromium.org
Closed: Mar 2018
Cc:
dgarr...@chromium.org
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Master release builds are marked as not important

Project Member Reported by jinjingl@chromium.org, Mar 22 2018 
From CIDB

mysql> select id, builder_name, important from buildTable where buildbucket_id = '8951422591655465376'; 
+---------+----------------+-----------+
| id      | builder_name   | important |
+---------+----------------+-----------+
| 2402049 | master-release |         0 |
+---------+----------------+-----------+

Comment 1 by dgarr...@chromium.org, Mar 22 2018

Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8e1c5810e60affa12b7085e5a61203ce0adf613a

commit 8e1c5810e60affa12b7085e5a61203ce0adf613a
Author: Don Garrett <dgarrett@google.com>
Date: Thu Mar 22 06:23:36 2018

chromeos_config: Mark master-release as important.

master-release wasn't marked as important. This causes no build
issues, but was causing display issues in go/legoland.

BUG= chromium:824582 
TEST=cbuildbot/chromeos_config_unittest

Change-Id: Iedcdab5267ddc274a113cd8742a31bf175b46514
Reviewed-on: https://chromium-review.googlesource.com/974654
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/8e1c5810e60affa12b7085e5a61203ce0adf613a/cbuildbot/config_dump.json
[modify] https://crrev.com/8e1c5810e60affa12b7085e5a61203ce0adf613a/cbuildbot/chromeos_config.py
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c55a0e3aa13c32d07b72ae7066c405808e8ae595

commit c55a0e3aa13c32d07b72ae7066c405808e8ae595
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Mar 22 11:39:44 2018

Roll src/third_party/chromite/ a1ec7e112..051b1952c (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a1ec7e112c5e..051b1952ca4b

$ git log a1ec7e112..051b1952c --date=short --no-merges --format='%ad %ae %s'
2018-02-21 smbarber chromeos_config: promote tatl from experimental
2018-03-21 dgarrett chromeos_config: Mark master-release as important.

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:814445 , chromium:824582 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7e9f8ce027937ff3b065c25f4c97e1ef77169f07
Reviewed-on: https://chromium-review.googlesource.com/974905
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545041}
[modify] https://crrev.com/c55a0e3aa13c32d07b72ae7066c405808e8ae595/DEPS

Comment 4 by dgarr...@chromium.org, Mar 22 2018

Status: Fixed (was: Started)
►

Sign in to add a comment