New issue
Advanced search Search tips

Issue 824570 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 817419



Sign in to add a comment

Illegal Thread Join in ToolbarViewInteractiveUITest.TestAppMenuOpensOnDrag

Project Member Reported by robliao@chromium.org, Mar 22 2018

Issue description

[8902:775:0321/165507.481382:FATAL:thread_restrictions.cc(29)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the TaskScheduler, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking in a narrow scope.
0   libbase.dylib                       0x000000011ec0df7e base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x000000011ec0e03d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x000000011ec0c4ec base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib                       0x000000011eca91ec logging::LogMessage::~LogMessage() + 460
4   libbase.dylib                       0x000000011eca6f55 logging::LogMessage::~LogMessage() + 21
5   libbase.dylib                       0x000000011ef0f28c base::AssertBlockingAllowed() + 188
6   libbase.dylib                       0x000000011eef23b8 base::PlatformThread::Join(base::PlatformThreadHandle) + 56
7   libbase.dylib                       0x000000011eeff575 base::Thread::Stop() + 293
8   libbase.dylib                       0x000000011eeff3c7 base::Thread::~Thread() + 39
9   libbase.dylib                       0x000000011eeff695 base::Thread::~Thread() + 21
10  libbase.dylib                       0x000000011eeff6b9 base::Thread::~Thread() + 25
11  interactive_ui_tests                0x0000000101ab455e ToolbarViewInteractiveUITest::FinishDragAndDrop(base::RepeatingCallback<void ()>) + 206
12  interactive_ui_tests                0x0000000101ab7c40 void base::internal::FunctorTraits<void (ToolbarViewInteractiveUITest::*)(base::RepeatingCallback<void ()>), void>::Invoke<ToolbarViewInteractiveUITest*, base::RepeatingCallback<void ()> >(void (ToolbarViewInteractiveUITest::*)(base::RepeatingCallback<void ()>), ToolbarViewInteractiveUITest*&&, base::RepeatingCallback<void ()>&&) + 176
13  interactive_ui_tests                0x0000000101ab7b4f void base::internal::InvokeHelper<false, void>::MakeItSo<void (ToolbarViewInteractiveUITest::*)(base::RepeatingCallback<void ()>), ToolbarViewInteractiveUITest*, base::RepeatingCallback<void ()> >(void (ToolbarViewInteractiveUITest::*&&)(base::RepeatingCallback<void ()>), ToolbarViewInteractiveUITest*&&, base::RepeatingCallback<void ()>&&) + 95
14  interactive_ui_tests                0x0000000101ab7acb void base::internal::Invoker<base::internal::BindState<void (ToolbarViewInteractiveUITest::*)(base::RepeatingCallback<void ()>), base::internal::UnretainedWrapper<ToolbarViewInteractiveUITest>, base::RepeatingCallback<void ()> >, void ()>::RunImpl<void (ToolbarViewInteractiveUITest::*)(base::RepeatingCallback<void ()>), std::__1::tuple<base::internal::UnretainedWrapper<ToolbarViewInteractiveUITest>, base::RepeatingCallback<void ()> >, 0ul, 1ul>(void (ToolbarViewInteractiveUITest::*&&)(base::RepeatingCallback<void ()>), std::__1::tuple<base::internal::UnretainedWrapper<ToolbarViewInteractiveUITest>, base::RepeatingCallback<void ()> >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 139
15  interactive_ui_tests                0x0000000101ab79d9 base::internal::Invoker<base::internal::BindState<void (ToolbarViewInteractiveUITest::*)(base::RepeatingCallback<void ()>), base::internal::UnretainedWrapper<ToolbarViewInteractiveUITest>, base::RepeatingCallback<void ()> >, void ()>::RunOnce(base::internal::BindStateBase*) + 57
16  libbase.dylib                       0x000000011ebaef6c base::OnceCallback<void ()>::Run() && + 92
17  libbase.dylib                       0x000000011ec105b3 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 947
18  libbase.dylib                       0x000000011ecf0a7a base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) + 234
19  libbase.dylib                       0x000000011ecfd766 base::MessageLoop::RunTask(base::PendingTask*) + 886
20  libbase.dylib                       0x000000011ecfdd39 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 89
21  libbase.dylib                       0x000000011ecfe06a base::MessageLoop::DoWork() + 570
22  libbase.dylib                       0x000000011ed0b5b2 base::MessagePumpCFRunLoopBase::RunWork() + 98
23  libbase.dylib                       0x000000011ed0b941 base::MessagePumpCFRunLoopBase::RunNestingDeferredWork() + 49
24  libbase.dylib                       0x000000011ed0b8fc ___ZN4base24MessagePumpCFRunLoopBase28RunNestingDeferredWorkSourceEPv_block_invoke + 28
25  libbase.dylib                       0x000000011ecae71a base::mac::CallWithEHFrame(void () block_pointer) + 10
26  libbase.dylib                       0x000000011ed0a555 base::MessagePumpCFRunLoopBase::RunNestingDeferredWorkSource(void*) + 101
27  CoreFoundation                      0x00007fff33ebaa21 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
28  CoreFoundation                      0x00007fff33f7226c __CFRunLoopDoSource0 + 108
29  CoreFoundation                      0x00007fff33e9db0c __CFRunLoopDoSources0 + 300
30  CoreFoundation                      0x00007fff33e9cf2d __CFRunLoopRun + 1293
31  CoreFoundation                      0x00007fff33e9c787 CFRunLoopRunSpecific + 487
32  HIToolbox                           0x00007fff331a9e26 RunCurrentEventLoopInMode + 286
33  HIToolbox                           0x00007fff331a9b96 ReceiveNextEventCommon + 613
34  HIToolbox                           0x00007fff331a9914 _BlockUntilNextEventMatchingListInModeWithFilter + 64
35  AppKit                              0x00007fff31474f5f _DPSNextEvent + 2085
36  AppKit                              0x00007fff31c0ab4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044
37  interactive_ui_tests                0x000000010491d6ca __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 106
38  libbase.dylib                       0x000000011ecae71a base::mac::CallWithEHFrame(void () block_pointer) + 10
39  interactive_ui_tests                0x000000010491d568 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 248
40  AppKit                              0x00007fff31469d6d -[NSApplication run] + 764
41  libbase.dylib                       0x000000011ed0cc0c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 348
42  libbase.dylib                       0x000000011ed09ad5 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 101
43  libbase.dylib                       0x000000011ecfcf1d base::MessageLoop::Run(bool) + 573
44  libbase.dylib                       0x000000011edfe6fe base::RunLoop::Run() + 606
45  interactive_ui_tests                0x00000001064a7fa4 content::RunThisRunLoop(base::RunLoop*) + 52
46  interactive_ui_tests                0x00000001064aa14f content::MessageLoopRunner::Run() + 239
47  interactive_ui_tests                0x0000000101ab41a1 ToolbarViewInteractiveUITest::DoDragAndDrop(gfx::Point const&, gfx::Point const&) + 2417
48  interactive_ui_tests                0x0000000101ab5241 ToolbarViewInteractiveUITest_TestAppMenuOpensOnDrag_Test::RunTestOnMainThread() + 1873
49  interactive_ui_tests                0x00000001064537ad content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 2093
 
Labels: MacViews-Browser
Owner: robliao@chromium.org
Status: Assigned (was: Available)
Assigning this directly to you, Rob.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ce4960aa9888967e6c53a87bf5dd073215ab974

commit 5ce4960aa9888967e6c53a87bf5dd073215ab974
Author: Robert Liao <robliao@chromium.org>
Date: Thu Mar 22 12:53:32 2018

Disable ToolbarViewInteractiveUITest.TestAppMenuOpensOnDrag on Mac

This test contains an illegal thread join that likely impacts other
platforms.

Windows doesn't hit it because Windows does not yet DCHECK on thread
joins on the UI thread.

BUG=824570

Change-Id: If8e8f4b0620f6184986478c20eeef21fa68f749a
Reviewed-on: https://chromium-review.googlesource.com/974569
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545051}
[modify] https://crrev.com/5ce4960aa9888967e6c53a87bf5dd073215ab974/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

Labels: MacViews-Tests
Labels: Target-68

Comment 5 by gov...@chromium.org, Apr 13 2018

Labels: Proj-MacViews
Labels: M-68

Comment 7 by gov...@chromium.org, Apr 25 2018

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.

Comment 8 by gov...@chromium.org, May 22 2018

M68 branch is coming soon on this Thursday, 05/24 and M68 Beta promotion is on 06/07. 
This bug is marked as P1 for M68. Pls land the fix to trunk ASAP (if possible before 4:00 PM PT this Thursday in order to make it to M68 branch build cut. Thank you.
Labels: -Pri-1 Pri-2
This only has test impact. Adjusting to P2.
Labels: -Target-68 Target-69
Labels: -M-68 Group-Tests
Labels: M-68
Labels: -M-68 M-69
Labels: -M-69 -Target-69 M-70 Target-70

Sign in to add a comment