Move feedbackPrivate custom bindings to //extensions |
||
Issue descriptionIn Chrome, chrome.feedbackPrivate.sendFeedback converts some optional properties to blobs [1]. This is used to attach a file and/or screenshot. The Hotrod app uses this to upload its JS logs. To support this in AppShell, we need to move feedback_private_custom_bindings.js to //extensions. [1] https://cs.chromium.org/chromium/src/chrome/renderer/resources/extensions/feedback_private_custom_bindings.js?q=attachedFile&sq=package:chromium&l=18&dr=C
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/feab23606d5a61eb822d40f5ab80707dc319d001 commit feab23606d5a61eb822d40f5ab80707dc319d001 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Thu Mar 22 20:24:40 2018 Move feedbackPrivate's custom bindings to //extensions Most of the chrome.feedbackPrivate implementation lives in //extensions, but the custom bindings used to transform blobs into UUIDs still live in //chrome. This just moves them into //extensions so that extensions running in non-Chrome embedders can attach a file and/or screenshot to the FeedbackInfo sent via chrome.feedbackPrivate.sendFeedback. Bug: 824563 Change-Id: Ief8a53905f1d9e9afec66374ea63b611636a8ed4 Reviewed-on: https://chromium-review.googlesource.com/974754 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545220} [modify] https://crrev.com/feab23606d5a61eb822d40f5ab80707dc319d001/chrome/renderer/BUILD.gn [modify] https://crrev.com/feab23606d5a61eb822d40f5ab80707dc319d001/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc [modify] https://crrev.com/feab23606d5a61eb822d40f5ab80707dc319d001/chrome/renderer/resources/renderer_resources.grd [modify] https://crrev.com/feab23606d5a61eb822d40f5ab80707dc319d001/extensions/renderer/BUILD.gn [modify] https://crrev.com/feab23606d5a61eb822d40f5ab80707dc319d001/extensions/renderer/dispatcher.cc [modify] https://crrev.com/feab23606d5a61eb822d40f5ab80707dc319d001/extensions/renderer/resources/extensions_renderer_resources.grd [rename] https://crrev.com/feab23606d5a61eb822d40f5ab80707dc319d001/extensions/renderer/resources/feedback_private_custom_bindings.js
,
May 9 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by michae...@chromium.org
, Mar 22 2018