New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824562 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::Document::SetCompatibilityMode

Project Member Reported by ClusterFuzz, Mar 21 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5145786074267648

Fuzzer: attekett_dom_fuzzer
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000033c
Crash State:
  blink::Document::SetCompatibilityMode
  blink::HTMLConstructionSite::SetDefaultCompatibilityMode
  blink::HTMLTreeBuilder::ProcessStartTag
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=536350:536351

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5145786074267648

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 22 2018

Components: Blink>DOM Blink>HTML>Parser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 22 2018

Labels: Test-Predator-Auto-Owner
Owner: lfg@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/e5d27a36230aea4b3664f8b5345b09bb0690a3ff (Ensure that an OOPIF renderer knows its size before layout.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by lfg@chromium.org, Mar 23 2018

Unable to repro. I've asked clusterfuzz to retry this test.

Comment 4 by lfg@chromium.org, Mar 28 2018

I'm still unable to repro, but I put up a speculative fix at https://chromium-review.googlesource.com/c/chromium/src/+/984037.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8dcacf8e9cf851e26421642548c2cbaf60eb28a

commit c8dcacf8e9cf851e26421642548c2cbaf60eb28a
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Wed Apr 04 01:08:02 2018

Do not append bytes to the parser if was stopped or detached.

Bug:  824562 
Change-Id: Ib7af477a49036204517d6115e45cba2ce721ef2b
Reviewed-on: https://chromium-review.googlesource.com/984037
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547912}
[modify] https://crrev.com/c8dcacf8e9cf851e26421642548c2cbaf60eb28a/third_party/WebKit/Source/core/html/parser/TextDocumentParser.cpp

Project Member

Comment 6 by ClusterFuzz, Apr 4 2018

ClusterFuzz has detected this issue as fixed in range 547859:547860.

Detailed report: https://clusterfuzz.com/testcase?key=5145786074267648

Fuzzer: attekett_dom_fuzzer
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000033c
Crash State:
  blink::Document::SetCompatibilityMode
  blink::HTMLConstructionSite::SetDefaultCompatibilityMode
  blink::HTMLTreeBuilder::ProcessStartTag
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=536350:536351
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=547859:547860

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5145786074267648

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Apr 4 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5145786074267648 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 8 by lfg@chromium.org, Apr 10 2018

Cc: brajkumar@chromium.org lfg@chromium.org
 Issue 828992  has been merged into this issue.

Sign in to add a comment