New issue
Advanced search Search tips

Issue 824551 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 817419



Sign in to add a comment

MacViews - Creating Multiple Modal Dialogs Creates Multiple Focus Managers

Project Member Reported by robliao@chromium.org, Mar 21 2018

Issue description

This causes interactive_ui_tests ConstrainedWindowViewTest.FocusTest to fail.
 
Labels: MacViews-Browser
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d983e1ec5618c6a4301fec7eba58570cc2dfb29

commit 9d983e1ec5618c6a4301fec7eba58570cc2dfb29
Author: Robert Liao <robliao@chromium.org>
Date: Thu Mar 22 12:52:01 2018

Disable ConstrainedWindowViewTest.FocusTest for MacViews

There are unexpectedly multiple focus managers in this test.

BUG=824551

Change-Id: Id1d79745de9fb7ed1dd96c4224d9e57fb21ef8cd
Reviewed-on: https://chromium-review.googlesource.com/974521
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545049}
[modify] https://crrev.com/9d983e1ec5618c6a4301fec7eba58570cc2dfb29/chrome/browser/ui/views/constrained_window_views_browsertest.cc

Labels: Target-68
Owner: robliao@chromium.org
Status: Assigned (was: Available)
Summary: MacViews - Creating Multiple Modal Dialogs Creates Multiple Focus Managers (was: MacVIews - Creating Multiple Modal Dialogs Creates Multiple Focus Managers)
robliao, can you sort this out by M-68? How bad is this bug?
Labels: MacViews-Tests

Comment 5 by gov...@chromium.org, Apr 13 2018

Labels: Proj-MacViews
Labels: M-68
Labels: Sprint-1

Comment 8 by gov...@chromium.org, Apr 25 2018

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
Labels: Sprint-2
Can we remove "Sprint-1" label as "Sprint-2" is already applied at #9?
Labels: -Sprint-1
Removing "Sprint-1" label per https://bugs.chromium.org/p/chromium/issues/detail?id=712244#c11.
Any progress here?
M68 branch is coming soon on this Thursday, 05/24 and M68 Beta promotion is on 06/07. 
This bug is marked as P1 for M68. Pls land the fix to trunk ASAP (if possible before 4:00 PM PT this Thursday in order to make it to M68 branch build cut. Thank you.
Labels: -Pri-1 Pri-2
This only has test impact. Adjusting to P2.
Labels: -Target-68 Target-69
Labels: -M-68 Group-Tests
Labels: M-68
Labels: -M-68 M-69
Labels: -M-69 -Target-69 M-70 Target-70

Sign in to add a comment