When a Crostini app is pinned on the Shelf and no instance is running, click it should invoke an instance.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c9b25b10292175c60e3a9238ae72f3e9770060 commit d4c9b25b10292175c60e3a9238ae72f3e9770060 Author: Timothy Loh <timloh@chromium.org> Date: Thu Apr 12 06:51:25 2018 Add a basic context menu to Crostini app launcher items This patch adds a context menu for Crostini app launcher items, of which the only entry is "Pin to shelf" (or Unpin), inherited from the default context menu -- note that clicking pinned entries currently does nothing and the shelf icon is missing. Eventually we'd like to support also "App info" and "Uninstall" entries. Bug: 824549 Change-Id: Iee3038707b67232f6d813ecca5b675df973a86e7 Reviewed-on: https://chromium-review.googlesource.com/1006564 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#550054} [modify] https://crrev.com/d4c9b25b10292175c60e3a9238ae72f3e9770060/chrome/browser/ui/BUILD.gn [add] https://crrev.com/d4c9b25b10292175c60e3a9238ae72f3e9770060/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.cc [add] https://crrev.com/d4c9b25b10292175c60e3a9238ae72f3e9770060/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.h [modify] https://crrev.com/d4c9b25b10292175c60e3a9238ae72f3e9770060/chrome/browser/ui/app_list/crostini/crostini_app_item.cc [modify] https://crrev.com/d4c9b25b10292175c60e3a9238ae72f3e9770060/chrome/browser/ui/app_list/crostini/crostini_app_item.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8503ed204436b6a5d7f0fd5417f8263752acfc8 commit f8503ed204436b6a5d7f0fd5417f8263752acfc8 Author: Timothy Loh <timloh@chromium.org> Date: Mon Apr 23 09:06:39 2018 Basic functionality for pinned Crostini Apps This patch adds support for launching Crostini Apps that have been pinned on the Shelf, as well as the title which is shown on hover. The code for launching apps in CrostiniAppItem has been moved to crostini_util.cc so it can be shared. Bug: 824549 Change-Id: If0ee8e29c7202bf9a87bcedd3ce3b7edc5c9651c Reviewed-on: https://chromium-review.googlesource.com/1011485 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552654} [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/chromeos/crostini/crostini_registry_service.cc [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/chromeos/crostini/crostini_registry_service.h [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/chromeos/crostini/crostini_util.cc [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/chromeos/crostini/crostini_util.h [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/ui/app_list/crostini/crostini_app_item.cc [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/ui/app_list/crostini/crostini_app_model_builder.cc [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/ui/app_list/crostini/crostini_installer_view.h [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/ui/app_list/crostini/crostini_installer_view_browsertest.cc [modify] https://crrev.com/f8503ed204436b6a5d7f0fd5417f8263752acfc8/chrome/browser/ui/ash/launcher/launcher_controller_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a175efb40e0daddbb849774cc474f8b9b9a96dd commit 3a175efb40e0daddbb849774cc474f8b9b9a96dd Author: Timothy Loh <timloh@chromium.org> Date: Sat Apr 28 08:17:23 2018 Support pinning and unpinning Crostini apps from the shelf This patch adds the pin/unpin entry to the context menu for Crostini apps on the shelf. Crostini windows which are not associated with a desktop file do not get this context menu item. Bug: 824549 Change-Id: I91ec27dc909804e44a3b98b4f38a281b8243d262 Reviewed-on: https://chromium-review.googlesource.com/1032192 Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554641} [modify] https://crrev.com/3a175efb40e0daddbb849774cc474f8b9b9a96dd/chrome/browser/ui/ash/launcher/crostini_shelf_context_menu.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2bb836f397ceaecb8bd403ff3ffb2d667c54a81 commit a2bb836f397ceaecb8bd403ff3ffb2d667c54a81 Author: Timothy Loh <timloh@chromium.org> Date: Mon Apr 30 12:13:09 2018 Detect the Crosh instance for the Crostini Terminal as a Crostini App. This patch adds a override_app_name field to AppLaunchParams, which is used when launching Crosh (for the Crostini Terminal) to set it to a value that the CrostiniAppWindowShelfController can identify as a Crostini App. Similar to v1 packaged apps which prefix with "_crx_", we prefix with "_crostini_". Previously, the opened window (crosh) would be separate to the Terminal if it were pinned from the App List. Pinning the crosh to the shelf resulted in an icon that only opened chrome://extensions. This patch fixes this so the opened window is the same as a pinned terminal from the App List. Bug: 824549 Change-Id: Ifef0d5b476c5389639c0436ba272037710245ea6 Reviewed-on: https://chromium-review.googlesource.com/1034555 Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#554725} [modify] https://crrev.com/a2bb836f397ceaecb8bd403ff3ffb2d667c54a81/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/a2bb836f397ceaecb8bd403ff3ffb2d667c54a81/chrome/browser/chromeos/crostini/crostini_util.cc [modify] https://crrev.com/a2bb836f397ceaecb8bd403ff3ffb2d667c54a81/chrome/browser/chromeos/crostini/crostini_util.h [modify] https://crrev.com/a2bb836f397ceaecb8bd403ff3ffb2d667c54a81/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc [modify] https://crrev.com/a2bb836f397ceaecb8bd403ff3ffb2d667c54a81/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.h [modify] https://crrev.com/a2bb836f397ceaecb8bd403ff3ffb2d667c54a81/chrome/browser/ui/extensions/app_launch_params.h [modify] https://crrev.com/a2bb836f397ceaecb8bd403ff3ffb2d667c54a81/chrome/browser/ui/extensions/application_launch.cc
Issue 838331 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c7184260727f5015e710e58810abed5163d37f0 commit 4c7184260727f5015e710e58810abed5163d37f0 Author: Tim Zheng <timzheng@google.com> Date: Thu May 24 01:25:00 2018 Correct a typo. Bug: 824549 Change-Id: Ifd8d5c83b2c62d4cdf60cc8f0345f5a736e49a66 Reviewed-on: https://chromium-review.googlesource.com/1067681 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561350} [modify] https://crrev.com/4c7184260727f5015e710e58810abed5163d37f0/chrome/browser/chromeos/crostini/crostini_util.cc
Comment 1 by bugdroid1@chromium.org
, Apr 12 2018