New issue
Advanced search Search tips

Issue 824536 link

Starred by 2 users
Status: Fixed
Owner:
corising@chromium.org
Closed: Sep 28
Cc:
pbos@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Permission request bubble (triggered from js) doesn't highlight security chip

Project Member Reported by bettes@chromium.org, Mar 21 2018 
Windows, Canary 67.0.3377.0

- USB:  crbug.com/654137 
- Permission request (navigate to permission.site)
- Bluetooth:  crbug.com/654137 
- Cant update Chrome: crbug.com/651648

Comment 1 by bettes@chromium.org, Mar 21 2018

2018-03-21_15-56-18.png
172 KB View Download

Comment 2 by bsep@chromium.org, Apr 6 2018

Labels: -OS-Linux -OS-Chrome OS-Android OS-iOS OS-Mac
Owner: pbos@chromium.org
pbos@ please look at this when you have time

Comment 3 by bsep@chromium.org, Apr 6 2018

Labels: -OS-Android -OS-iOS OS-Chrome OS-Linux
Not sure what happened to the OS labels there.

Comment 4 by bsep@chromium.org, Apr 18 2018 

As pointed out by  bug 829700 , the "restore pages" bubble also doesn't highlight the hamburger menu button.

Comment 5 by robliao@chromium.org, Jun 13 2018

Labels: Proj-MdRefresh
Marking Proj-MdRefresh for triage.

Comment 6 by robliao@chromium.org, Jun 13 2018

Labels: Hotlist-Helper

Comment 7 by bettes@chromium.org, Jun 13 2018 

Same design as our page info anchor highlight
Screen Shot 2018-06-13 at 1.42.46 PM.png
64.1 KB View Download

Comment 8 by markchang@chromium.org, Jun 14 2018

Labels: -Pri-1 Pri-3
Status: Available (was: Untriaged)

Comment 9 by markchang@chromium.org, Jun 14 2018

Cc: pbos@chromium.org
Owner: ----

Comment 10 by robliao@chromium.org, Jun 28 2018

Labels: Hotlist-Polish

Comment 11 by pbos@chromium.org, Jul 10

Owner: corising@chromium.org
Status: Assigned (was: Available)

Comment 12 by robliao@chromium.org, Jul 12

Labels: Group-Toolbar

Comment 13 by robliao@chromium.org, Jul 24

Status: WontFix (was: Assigned)
Triage: This is not part of the spec. Let's make this consistent with the In-Product Help behavior.

Comment 14 by pbos@chromium.org, Jul 24

Status: Assigned (was: WontFix)
Summary: Permission request bubble (triggered from js) doesn't highlight security chip (was: Missing anchor (highlight) UI for windows popovers)
I'll reopen this to cover the missing anchor effect when the permissions bubble is triggered from javascript. If that's covered elsewhere please refer/dedup into the issue.

Comment 15 by robliao@chromium.org, Jul 26

Labels: M-70 Target-70

Comment 16 by robliao@chromium.org, Aug 20

Labels: -Target-70 -M-70 Target-71 M-71

Comment 17 by robliao@chromium.org, Aug 21

Labels: Proj-DesktopUI

Comment 18 by robliao@chromium.org, Sep 13

Labels: Hotlist-MdRefreshDesignPolish
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e767f87e7a62609817cff5bce1de36a4d60dfbd5

commit e767f87e7a62609817cff5bce1de36a4d60dfbd5
Author: Caroline Rising <corising@chromium.org>
Date: Tue Sep 18 19:04:47 2018

Add inkdrop highlighting to buttons with anchored widgets.

Add method to make buttons observers of any widgets that are anchored to them. Change inkdrop highlight for buttons when anchored widgets are shown or removed. Fix cases where a widget is anchored to the location bar but a different view should be highlighted. Change highlighting to SetBackground when used for extension actions in BrowserActionsContainer to protect inkdrop highlight state during layout calls.

Bug:  863170 ,  824536 
Change-Id: Id6abdfa7a70955b3cb1873b6c8013f0496455f68
Reviewed-on: https://chromium-review.googlesource.com/1165601
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592131}
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ash/shelf/overflow_button.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/cocoa/translate/translate_bubble_bridge_views.mm
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/bubble_anchor_util_views.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/bubble_anchor_util_views.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/star_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/star_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/page_action/page_action_icon_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/page_action/page_action_icon_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/passwords/password_bubble_view_base.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/translate/translate_bubble_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/bubble/bubble_dialog_delegate_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/bubble/bubble_dialog_delegate_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/bubble/bubble_dialog_delegate_view_unittest.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/controls/button/button.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/controls/button/button.h

Comment 20 by robliao@chromium.org, Sep 20

Labels: -Proj-MdRefresh

Comment 21 by robliao@chromium.org, Sep 26

Labels: Hotlist-DesktopUITriaged

Comment 22 by corising@chromium.org, Sep 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment