New issue
Advanced search Search tips

Issue 824528 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in viz::Display::RemoveOverdrawQuads

Project Member Reported by ClusterFuzz, Mar 21 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4671133962731520

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  viz::Display::RemoveOverdrawQuads
  viz::Display::DrawAndSwap
  viz::DisplayScheduler::DrawAndSwap
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=544499:544510

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4671133962731520

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 21 2018

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 21 2018

Cc: erikc...@chromium.org yiyix@chromium.org samans@chromium.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

viz: Implement RGBA readback for FrameSinkVideoCapturer by samans@chromium.org - https://chromium.googlesource.com/chromium/src/+/00d3544e2e7b3215e55549e1b0ff5b5d86098071

Draw Occlusion: Enable Draw Occlusion by Default by yiyix@chromium.org - https://chromium.googlesource.com/chromium/src/+/ab34a89965a54a64b594463aabd9320ddde1960e

Add back debugging logic to CollectMemoryUsageAndDie. by erikchen@chromium.org - https://chromium.googlesource.com/chromium/src/+/ff3e4e28d1428990266669920579f3cea0e007e9

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.

Comment 3 by samans@chromium.org, Mar 21 2018

Owner: yiyix@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by ClusterFuzz, Mar 22 2018

ClusterFuzz has detected this issue as fixed in range 544675:544677.

Detailed report: https://clusterfuzz.com/testcase?key=4671133962731520

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  viz::Display::RemoveOverdrawQuads
  viz::Display::DrawAndSwap
  viz::DisplayScheduler::DrawAndSwap
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=544499:544510
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=544675:544677

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4671133962731520

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Mar 22 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4671133962731520 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be775f31adc20187ec78c7ecab0d384b6d8d51c5

commit be775f31adc20187ec78c7ecab0d384b6d8d51c5
Author: yiyix <yiyix@chromium.org>
Date: Tue Mar 27 19:18:34 2018

Fix Regression: Integer-overflow in viz::Display::RemoveOverdrawQuads

I used a size_t type variable to record the total number of pixels on
screen for some UMA metrics. However, with extreme large DrawQuads,
size_t is not enough to store the total number of pixels.

Bug:  824528 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1309ae31757da3b8e9ae689910575e8fa2ed2316
Reviewed-on: https://chromium-review.googlesource.com/976626
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546197}
[modify] https://crrev.com/be775f31adc20187ec78c7ecab0d384b6d8d51c5/components/viz/service/display/display.cc
[modify] https://crrev.com/be775f31adc20187ec78c7ecab0d384b6d8d51c5/components/viz/service/display/display_unittest.cc

Sign in to add a comment