New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824524 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
(currently inactive on Chromium)
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Handle VR Services being out of date when Chrome is launched in VR

Project Member Reported by mthiesse@chromium.org, Mar 21 2018

Issue description

When Chrome is launched from any intent, including Daydream home/deep-links, we need to handle the case where the VR services installed are too old for Chrome.

We should be able to show doff, then request that the user updates their VR services.
 

Comment 1 by ymalik@chromium.org, Mar 29 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cffaa6f6b1e36a3914ef181078f304f861793cce

commit cffaa6f6b1e36a3914ef181078f304f861793cce
Author: Yash Malik <ymalik@google.com>
Date: Fri Apr 06 16:21:15 2018

VR: DOFF if VR Services need to be updated

Befort this CL, we would just ignore a VR intent if the VR services were out of
date. In this CL, we show the DOFF, and show the update infobar in 2D.

For DLAs some reason, intenting out to the play store sometimes results in
Android dropping the intent, so we keep the CCT alive if the DON flow is
successful and show the infobar.

Bug:  824524 
Change-Id: I2387b270a2e9c18f941e4a433309749f6ef25f87
Reviewed-on: https://chromium-review.googlesource.com/997018
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548798}
[modify] https://crrev.com/cffaa6f6b1e36a3914ef181078f304f861793cce/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
[modify] https://crrev.com/cffaa6f6b1e36a3914ef181078f304f861793cce/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrIntentUtils.java
[modify] https://crrev.com/cffaa6f6b1e36a3914ef181078f304f861793cce/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/cffaa6f6b1e36a3914ef181078f304f861793cce/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockVrIntentHandler.java

Status: Fixed (was: Started)

Comment 4 by ymalik@chromium.org, Apr 17 2018

Issue 764777 has been merged into this issue.
Labels: Test-Complete
Status: Verified (was: Fixed)
Verified on build 67.0.3396.29 beta.  Looks good.

Sign in to add a comment