New issue
Advanced search Search tips

Issue 824517 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 817419



Sign in to add a comment

interactive_ui_tests MacViews Entering Fullscreen is Flaky

Project Member Reported by robliao@chromium.org, Mar 21 2018

Issue description

Entering fullscreen is flaky on Mac. Maybe because of the animation?
 
Labels: MacViews-Browser
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5f22f6815a0a821c646d5a418460ff77bc43c0f

commit c5f22f6815a0a821c646d5a418460ff77bc43c0f
Author: Robert Liao <robliao@chromium.org>
Date: Thu Mar 22 15:42:37 2018

Disable Flaky Fullscreen Entry Tests on Mac

BUG=824517
TBR=rdevlin.cronin@chromium.org
Disabling a test.

Change-Id: Ieead48926aad1ed9ced951e47a9ff114e4a8e8a1
Reviewed-on: https://chromium-review.googlesource.com/974313
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545079}
[modify] https://crrev.com/c5f22f6815a0a821c646d5a418460ff77bc43c0f/chrome/browser/extensions/extension_fullscreen_apitest.cc
[modify] https://crrev.com/c5f22f6815a0a821c646d5a418460ff77bc43c0f/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view_interactive_uitest.cc

Labels: MacViews-Tests
Labels: Target-68
Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)

Comment 5 by gov...@chromium.org, Apr 13 2018

Labels: Proj-MacViews
Labels: M-68

Comment 7 by gov...@chromium.org, Apr 25 2018

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
Labels: Sprint-2
Any progress here?
M68 branch is coming soon on this Thursday, 05/24 and M68 Beta promotion is on 06/07. 
This bug is marked as P1 for M68. Pls land the fix to trunk ASAP (if possible before 4:00 PM PT this Thursday in order to make it to M68 branch build cut. Thank you.
This is a flaky tests failure, is this still P1 for M68?
Labels: -Pri-1 Pri-2
Nope! P2 sounds reasonable.
Labels: -Target-68 Target-69
Labels: -M-68 Group-Tests
Labels: M-68
Labels: -M-68 M-69
Labels: -M-69 -Target-69 M-70 Target-70
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01c6712b6152df8e9fec63644e1f9f69f14965c0

commit 01c6712b6152df8e9fec63644e1f9f69f14965c0
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Jan 10 17:56:31 2019

views: re-annotate Mac fullscreen tests

Four of these tests were marked as "flaky" but in fact are testing UI that is
not used on Mac, so they are now compiled out. The last was flaky but now
seems not to be, so it is re-enabled.

Bug: 824517
Change-Id: Id5f788307f8b44c8487ede2ef006450387fe6400
Reviewed-on: https://chromium-review.googlesource.com/c/1403514
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621630}
[modify] https://crrev.com/01c6712b6152df8e9fec63644e1f9f69f14965c0/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view_interactive_uitest.cc

Sign in to add a comment