Can't generate_gradle anymore |
||
Issue descriptionI'm synced to 6bd3f30a5dacfbed5a6d01232b4c2305e4c9960e and generate_gradle fails: src$ build/android/gradle/generate_gradle.py --output-directory=out/Debug W 0.000s Main Creating project at: /usr/local/google/code/clankium2/src/out/Debug/gradle ninja: Entering directory `/usr/local/google/code/clankium2/src/out/Debug' ninja: no work to do. W 8.023s Main Building .build_config files... ninja: Entering directory `/usr/local/google/code/clankium2/src/out/Debug' ninja: no work to do. Traceback (most recent call last): File "build/android/gradle/generate_gradle.py", line 894, in <module> main() File "build/android/gradle/generate_gradle.py", line 820, in main e.GetType() in ('android_apk', 'java_binary', 'junit_binary') or File "build/android/gradle/generate_gradle.py", line 225, in GetType return self.DepsInfo()['type'] File "build/android/gradle/generate_gradle.py", line 215, in DepsInfo return self.BuildConfig()['deps_info'] File "build/android/gradle/generate_gradle.py", line 211, in BuildConfig self._build_config = build_utils.ReadJson(_RebasePath(path)) File "build/android/gradle/../gyp/util/build_utils.py", line 146, in ReadJson with open(path, 'r') as jsonfile: IOError: [Errno 2] No such file or directory: '/usr/local/google/code/clankium2/src/out/Debug/gen/copy_cronet_java8_java_/cronet_api_java.build_config' There is no such file, but there is /usr/local/google/code/clankium2/src/out/Debug/gen/components/cronet/android/copy_cronet_java8_java_:cronet_api_java.build_config I suspect the issue is caused by crrev.com/c/960583, which added the following: + # _copy_target_name includes ${dep} which includes "_java", so in turn + # _copy_target_name contains "_java" which triggers + # build/config/android/internal_rules.gni whitelist of target names that + # must have build_configs, so emit one here. + write_build_config("${_copy_target_name}__build_config") { + build_config = "$target_gen_dir/$_copy_target_name.build_config" + type = "group" + } Reverting that CL fixes the issue.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c486688e7c7be36cae68935b9a7f3bd0315a332c commit c486688e7c7be36cae68935b9a7f3bd0315a332c Author: Andrew Grieve <agrieve@chromium.org> Date: Thu Mar 22 01:48:05 2018 Android: Fix gradle project generation failure caused by odd cronet target name Also tweaks the cronet rules to not have to create dummy build_config targets. Bug: 824516 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia0d67c423060abbd6669fb37359f5588bc0ca38f Reviewed-on: https://chromium-review.googlesource.com/974712 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544941} [modify] https://crrev.com/c486688e7c7be36cae68935b9a7f3bd0315a332c/components/cronet/android/BUILD.gn
,
Mar 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by agrieve@chromium.org
, Mar 22 2018Owner: agrieve@chromium.org