Add unit tests for command buffer proxies |
|||
Issue descriptionAt one point, the proxies would just forward calls to IPC messages, so testing wasn't important. However, since the introduction of ordering barrier, sync tokens, and multi flush, they are responsible for ensuring correctness too, so testing is necessary.
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd979a834d0ec94736aac355a5bda93571899122 commit fd979a834d0ec94736aac355a5bda93571899122 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Mar 27 00:26:03 2018 ppapi: Unit tests for pepper command buffer proxy Similar to the IPC command buffer proxy unit tests. R=piman BUG= 824510 Change-Id: I14ecfc448e12d4f143b645cc9290c476fdbf5d0d Reviewed-on: https://chromium-review.googlesource.com/978959 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545899} [modify] https://crrev.com/fd979a834d0ec94736aac355a5bda93571899122/ppapi/BUILD.gn [modify] https://crrev.com/fd979a834d0ec94736aac355a5bda93571899122/ppapi/proxy/plugin_dispatcher.h [modify] https://crrev.com/fd979a834d0ec94736aac355a5bda93571899122/ppapi/proxy/ppapi_command_buffer_proxy.cc [modify] https://crrev.com/fd979a834d0ec94736aac355a5bda93571899122/ppapi/proxy/ppapi_command_buffer_proxy.h [add] https://crrev.com/fd979a834d0ec94736aac355a5bda93571899122/ppapi/proxy/ppapi_command_buffer_proxy_unittest.cc [modify] https://crrev.com/fd979a834d0ec94736aac355a5bda93571899122/ppapi/proxy/ppb_graphics_3d_proxy.cc
,
Mar 27 2018
,
Mar 27 2018
We have an initial set of unit tests which would've caught issue 797137. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Mar 23 2018