New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824509 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Incorrectly Printing some textboxes

Reported by alex.k.h...@gmail.com, Mar 21 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36

Steps to reproduce the problem:
1. Go to this link: https://jsfiddle.net/sdmg5uc7/17/
2. Print the full page

What is the expected behavior?
Everything prints as depicted on the screen

What went wrong?
Some of the textboxes (in the lower-right results screen) print with a grey fill/background

Did this work before? N/A 

Chrome version: 64.0.3282.186  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 29.0 r0

Seems tied to the borders of the textbox somehow. Both the fill it prints with and (most of) the borders have a color code of #696969.
 
Weird Gray Boxes - JSFiddle.pdf
210 KB Download
Labels: Needs-Triage-M64
Components: Internals>Printing
Cc: jmukthavaram@chromium.org nyerramilli@chromium.org
Labels: -Type-Bug -Pri-2 -Needs-Triage-M64 hasbisect-per-revision ReleaseBlock-Stable M-66 FoundIn-66 Target-66 FoundIn-65 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: halcanary@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on reported version 64.0.3282.186 ,stable-65.0.3325.181 & Beta-66.0.3359.66 using Mac 10.13.3, Windows 7 and Debian Rodate using fiddle given in comment#0. Observed some of the text boxes are filled with gray background.

Note: 
No issue on Dev-67.0.3381.1 & Canary-67.0.3382.0 ,hence provided reverse bisect.

First Good build--67.0.3367.0 -542330
Last Bad build--67.0.3366.0 -541888

Tool bisect Info:
----------------
You are probably looking for a change made after 542289 (known good), but no later than 542290 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/8bda86ec5975c41a756a0c95acd02324d37d86fb..dadab4dd963f914bde1b4019f835b9c0c5c895be

As above CL is skia,suspecting below :
https://skia.googlesource.com/skia.git/+/b4e528d7db05daeca7bb050d01e31e718c651de1

halcanary@Please take a look into it & reassign to the right owner if it is not related to your change.

As it is WAI on Canary , requesting merge to M66 if it is safe .
Thanks!
Labels: Merge-Request-66
I think it's https://skia.googlesource.com/skia.git/+/4e83ff1aa746e4bfd0c6470713084cc6783c367f instead.

Cherry-pick to m66 in progress: https://review.skia.org/117200
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 29 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 2 2018

Cc: halcanary@google.com abdulsyed@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Just a heads up, M66 Stable cut is on April 12th, 10 days away. This issue is marked as RB-Stable for 66. Please make sure to address this issue prior to stable cut. Thanks! 
Labels: -Merge-Approved-66
Labels: -Hotlist-Merge-Review
I'm guessing the merge is https://skia.googlesource.com/skia/+/cbd2d0f63e37a1be08dcb95fa257bb1fc294b0e6 - is a Skia DEPS roll also required on the M66 branch?
It should be automatic.
Great. Is this fixed then?
Status: Fixed (was: Assigned)
I just verified that it is fixed.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-66; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-66 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD merge-merged-3359

Sign in to add a comment