New issue
Advanced search Search tips

Issue 824505 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Window can't be selected in overview by tapping on the window in tablet mode

Project Member Reported by x...@chromium.org, Mar 21 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Enter tablet mode, open more than 2 windows, enter overview mode 
(2) Drag one window to snap to one side of the screen 
(3) Tap on the other window

What is the expected result?
The window is selected snapped to the other side of the screen

What happens instead?
The window stays in the overview



 

Comment 1 by x...@chromium.org, Mar 21 2018

Status: Started (was: Assigned)
It's a regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/970913. However, I think the root cause is a bug in WindowSelectorItem which got exposed by the CL. 
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa58702af161fff240ab4e8c91b368761f4f6df1

commit fa58702af161fff240ab4e8c91b368761f4f6df1
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Thu Mar 22 16:59:09 2018

Overview: Do not animate the bounds enlarge effect upon tapping on the item.

When an overview window item is tapped, it's enlarged slightly first to
indicate it's selected. We should enlarge it directly without any
animation. Otherwise, we might not get the correct event location.

Bug:  824505 
Change-Id: I7829edf1cab09eddf0335f5812fcb033f101915b
Reviewed-on: https://chromium-review.googlesource.com/974292
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545116}
[modify] https://crrev.com/fa58702af161fff240ab4e8c91b368761f4f6df1/ash/wm/overview/overview_animation_type.h
[modify] https://crrev.com/fa58702af161fff240ab4e8c91b368761f4f6df1/ash/wm/overview/scoped_overview_animation_settings.cc
[modify] https://crrev.com/fa58702af161fff240ab4e8c91b368761f4f6df1/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/fa58702af161fff240ab4e8c91b368761f4f6df1/ash/wm/overview/window_selector_unittest.cc

Comment 3 by x...@chromium.org, Mar 22 2018

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment