New issue
Advanced search Search tips

Issue 824493 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 823655



Sign in to add a comment

Many MSE_Widevine/EncryptedMediaTest browser_tests failing on Clang ToT waterfall

Project Member Reported by r...@chromium.org, Mar 21 2018

Issue description

I suspect this was caused by the removal of widevinecdmadapter in crrev.com/544557, but I haven't yet confirmed it.

Here is the first failing build on ClangToT:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin/1177

These tests are probably only built and run in official or branded Chrome builds. However, the internal official win trunk buildbots do not have those same browser_tests failures right now:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk?numbuilds=50
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/81472

That suggests that this might be caused by a change in upstream clang. I am attempting to reproduce the failures locally.
 

Comment 1 by r...@chromium.org, Mar 21 2018

These failures also appear on our official+branded win64 clang tot bot:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1134

It has crrev.com/544557 in the blame as well.

Comment 2 by r...@chromium.org, Mar 21 2018

Was this fixed by crrev.com/544770?

Comment 3 by r...@chromium.org, Mar 21 2018

I wasn't able to reproduce these widevine test failures locally. I guess we'll see if the next build comes back green.

Comment 4 by xhw...@chromium.org, Mar 21 2018

Cc: -xhw...@chromium.org
Owner: xhw...@chromium.org
Status: Assigned (was: Available)

Comment 5 by xhw...@chromium.org, Mar 21 2018

Should be caused by one of my CLs. I'll take a look.

Comment 6 by xhw...@chromium.org, Mar 21 2018

Re #3: I don't believe crrev.com/544770 will fix it. I suspect this is a swarming issue where the CDM is not send to the testing bots (pure guess). Trying to repro locally now.

Comment 7 by r...@chromium.org, Mar 21 2018

re c#6: Ah, not sending the file via swarming seems much more plausible. I ran the tests locally without swarming and they passed.

Comment 8 by xhw...@chromium.org, Mar 21 2018

Labels: -Pri-3 M-67 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a833a9a64ff54b3eee785705356a759637991a6

commit 1a833a9a64ff54b3eee785705356a759637991a6
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 22 21:27:26 2018

media: Widevine CDM binary/manifest as data_deps of "cdm" target

The swarming client needs this data_deps to put the CDM files in the
isolate (send them to the swarming bot).

We still need to keep the public_deps since it's needed to build the mac
bundle.

Bug:  772160 , 824493 

Test: Tested locally on a Linux box with is_chrome_branded, following
instructions on how to generate swarming isolate locally:
https://www.chromium.org/developers/testing/isolated-testing/for-swes#TOC-Run-a-test-built-locally-on-Swarming
More specifically, I tried load_library_perf_tests, which also depend on
the "cdm" target:
- ninja -C out/Debug -j1000 load_library_perf_tests
- echo gn > out/Debug/mb_type
- tools/mb/mb.py isolate //out/Debug load_library_perf_tests
With the fix, libwidevinecdm.so is in the isolate file.

Change-Id: I68f62a819302be811944614292db447c601cadcb
Reviewed-on: https://chromium-review.googlesource.com/976384
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545256}
[modify] https://crrev.com/1a833a9a64ff54b3eee785705356a759637991a6/third_party/widevine/cdm/BUILD.gn

Status: Fixed (was: Started)

Comment 11 by r...@chromium.org, Mar 23 2018

Thanks! I attempted to build browser_tests locally and run the tests via swarming like the bots do, but it was a complete failure. :(

Sign in to add a comment