New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 824472 link

Starred by 2 users
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: Apr 2018
Cc:
█ vollick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

WebVR URL toast should be updated to match new permissions indicators

Project Member Reported by cjgrant@chromium.org, Mar 21 2018 
WebVR permissions indicators are being reimplemented.  In parallel, the VR browser URL bar is being refactored.  When both of these are done, the new pieces of URL bar should be reused to build a new-style WebVR URL indicatator, according to the latest UX spec.

Comment 1 by cjgrant@chromium.org, Mar 27 2018

Status: Started (was: Assigned)
I have this working, but am having issues testing it live.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2df2cbc95bd21f26375cba9a120856c2ca9991db

commit 2df2cbc95bd21f26375cba9a120856c2ca9991db
Author: Christopher Grant <cjgrant@chromium.org>
Date: Wed Mar 28 20:55:52 2018

VR: Add URL to list of WebVR indicators

This change shows the URL and security icon as a WebVR indicator, along
with other indicators, when auto-presenting.

The URL text does not currently fade-elide properly, although
previously, we required that all deep-linked apps have short URLs
anyway.  For safety, elision will be fixed in a follow-on change.

BUG= 824472 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic35196ebde683b93eafb27f31fbae7b7c716900c
Reviewed-on: https://chromium-review.googlesource.com/984735
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546593}
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/databinding/binding.h
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/elements/indicator_spec.h
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/elements/url_bar.cc
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/elements/url_bar.h
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/elements/url_bar_texture.cc
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/elements/vector_icon.cc
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/elements/vector_icon.h
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/2df2cbc95bd21f26375cba9a120856c2ca9991db/chrome/browser/vr/ui_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/045cec8bc5c98827e8a063250162977daee52255

commit 045cec8bc5c98827e8a063250162977daee52255
Author: Christopher Grant <cjgrant@chromium.org>
Date: Tue Apr 03 16:38:59 2018

VR: Use Text element for most URL text rendering

This change completes the merge of URL rendering into VR's text system.
Text can now accept custom callbacks to run at two keys points during
text rendering.  This is done via callbacks to allow Text to continue
using its private texture class under the hood.

BUG= 824472 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1cd0b48f51f36435f0f79b51131cd2e1b48e93a9
Reviewed-on: https://chromium-review.googlesource.com/986670
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547732}
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/omnibox_formatting.cc
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/omnibox_formatting.h
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/omnibox_formatting_unittest.cc
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/render_text_wrapper.cc
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/render_text_wrapper.h
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/text.h
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/text_unittest.cc
[delete] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/chrome/browser/vr/elements/url_bar.cc
[delete] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/chrome/browser/vr/elements/url_bar.h
[delete] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/chrome/browser/vr/elements/url_bar_texture.cc
[delete] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/chrome/browser/vr/elements/url_bar_texture.h
[delete] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[add] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/url_text.cc
[add] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/url_text.h
[add] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/elements/url_text_unittest.cc
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/test/mock_render_text.h
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/045cec8bc5c98827e8a063250162977daee52255/chrome/browser/vr/ui_unittest.cc

Comment 4 by cjgrant@chromium.org, Apr 3 2018

Status: Fixed (was: Started)

Comment 5 by dougman@chromium.org, May 8 2018

Labels: Test-Complete
►

Sign in to add a comment