New issue
Advanced search Search tips

Issue 824459 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 631551



Sign in to add a comment

FR: suppress Auto-Submit when unresolved comments

Project Member Reported by benjamin...@google.com, Mar 21 2018

Issue description

From  bug 631551 #c35:

When auto-submit is enabled, if there are unresolved comments (i.e. comments where the "Resolved" box isn't checked), when I click Code-Review +1, rather than auto-selecting Commit-Queue +2 (with the standard message about auto-submit), leave the Commit-Queue as 0 and instead display a message saying something like, "Auto-Submit suppressed due to unresolved comments. Choose CQ+2 (or mark comments as resolved) to trigger submit."

My reasoning:
- If I add comments to the CL, I very likely want the author to consider making edits. I probably don't want to trigger CQ+2 in that case.
  - If I only added an "FYI" comment and didn't intend for the author to make changes, I should have marked the comment as Resolved. I can also override and choose CQ+2 if I want.
  - I still want to mark the CL as Code-Review +1 to indicate that the CL is fine as-is if the author decides not to make changes based on my comments.
- Maybe it's just because I'm used to the workflow without auto-submit, but I very nearly hit "Send" on a CL where I made a comment before noticing that it was marked CQ+2 due to auto-submit.
 

Comment 1 by aga...@chromium.org, Mar 27 2018

Cc: -rmis...@google.com
Owner: rmis...@google.com
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/8df2c258de161b7b5c555989d5262ff125e62c7e

commit 8df2c258de161b7b5c555989d5262ff125e62c7e
Author: Ravi Mistry <rmistry@google.com>
Date: Tue Mar 27 18:47:06 2018

Use updated change object when Code-Review label changes without a page load

This will now use the correct information to display the quick approve button.
This is not as bad as I suspected earlier because the change object is only refreshed
whenever the Code-Review label changes (not for ALL label changes).

Bug:  chromium:820117 , chromium:824459 
Change-Id: I1b394f73e539103609e209578dd8a05c88244dab
[modify] https://crrev.com/8df2c258de161b7b5c555989d5262ff125e62c7e/src/main/resources/static/chromium-behavior.html

Comment 3 by rmis...@google.com, Mar 30 2018

Submitted https://chromium-review.googlesource.com/c/infra/gerrit-plugins/chromium-behavior/+/980778 : Check for unresolved comments and drafts in reply dialog.

Waiting for review of https://chromium-review.googlesource.com/c/infra/gerrit-plugins/chromium-behavior/+/986674 : Notify if unresolved comments and/or drafts in the quick approve button.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/8f95970881d930f68748a5ed9450d7b2f80d927d

commit 8f95970881d930f68748a5ed9450d7b2f80d927d
Author: Ravi Mistry <rmistry@google.com>
Date: Fri Mar 30 17:24:13 2018

Notify if unresolved comments and/or drafts in the quick approve button

Bug:  chromium:824459 
Change-Id: I00c933560616f554527df8d59ecfc2f6992187e4
[modify] https://crrev.com/8f95970881d930f68748a5ed9450d7b2f80d927d/src/main/resources/static/chromium-behavior.html

Comment 5 by rmis...@google.com, Apr 12 2018

Status: Fixed (was: Started)
This is live and working. Marking as fixed.

Sign in to add a comment