PresentationReceiverWindowViewBrowserTest.ChromeOSHardwareFullscreenButton fails with --enable-features=Mash |
||||
Issue descriptionThe SetProperty(aura::client::kShowStateKey, ...) calls result in a massive recursion, and ultimately a segfault, in the ash_and_ui service process while it tries to set ash::kWindowShowStateKey. The cause is currently unknown so the test was submitted in the mash.browser_tests.filter file.
,
Apr 17 2018
estade@ has a patch out to fix this. Thanks!
,
Apr 17 2018
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/238373d52f13f13efb4d91a2b6504e20b7747e75 commit 238373d52f13f13efb4d91a2b6504e20b7747e75 Author: Evan Stade <estade@chromium.org> Date: Tue Oct 09 15:50:57 2018 [Mash] make PresentationReceiverWindowView observe correct window for fullscreen changes. Also, observe aura::client::kShowStateKey instead of ash::kWindowStateTypeKey. This makes sure that the property changes stay in sync with Widget::GetFullscreen, which relies on aura::client::kShowStateKey. Manual test: - run Chrome OS with multiple displays - use presentation API: https://googlechrome.github.io/samples/presentation-api/ - select display - toggle fullscreen with hardware button (f4) Bug: 824458 Change-Id: I433c981753480c63bc3ff06563aae5dc39806b78 Reviewed-on: https://chromium-review.googlesource.com/c/1014398 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#597927} [modify] https://crrev.com/238373d52f13f13efb4d91a2b6504e20b7747e75/chrome/browser/ui/views/media_router/presentation_receiver_window_view.cc [modify] https://crrev.com/238373d52f13f13efb4d91a2b6504e20b7747e75/chrome/browser/ui/views/media_router/presentation_receiver_window_view.h [modify] https://crrev.com/238373d52f13f13efb4d91a2b6504e20b7747e75/chrome/browser/ui/views/media_router/presentation_receiver_window_view_browsertest.cc
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40d7687614589e5e8aeef8df3aa824487019548f commit 40d7687614589e5e8aeef8df3aa824487019548f Author: Evan Stade <estade@chromium.org> Date: Wed Oct 10 18:16:32 2018 Update mash browsertest filter file after fixing PresentationReceiverWindowViewBrowserTest Fix was 238373d52f13f13efb4d9 Bug: 824458 Change-Id: I7c9955a48ec310e68ff805b6f1996b15d49f05c4 Reviewed-on: https://chromium-review.googlesource.com/c/1272440 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#598406} [modify] https://crrev.com/40d7687614589e5e8aeef8df3aa824487019548f/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter [modify] https://crrev.com/40d7687614589e5e8aeef8df3aa824487019548f/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Nov 7
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mfo...@chromium.org
, Apr 5 2018