New issue
Advanced search Search tips

Issue 824453 link

Starred by 1 user
Status: Fixed
Owner:
wzang@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 800945



Sign in to add a comment

Create a "current wallpaper" info bar for the new wallpaper picker

Project Member Reported by wzang@chromium.org, Mar 21 2018 
Right after opening the new wallpaper picker, an info bar should be shown that contains a thumbnail of the current wallpaper image, as well as some descriptive texts of the wallpaper.

See mock: https://drive.google.com/file/d/1O7jrpDRq_abx93d-xyCKdof5nID9y3dR/view?usp=sharing
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52327b7c8438e37862cd935304006b39f88f5b41

commit 52327b7c8438e37862cd935304006b39f88f5b41
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Mar 22 03:33:15 2018

cros: Add "current wallpaper" info bar to wallpaper picker

The entire new wallpaper picker is hidden behind flag. A mock of the
info bar: https://goo.gl/NTLuik

Bug:  824453 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8cb106f76fc01fef361ed3c7ca0f0253484518c5
Reviewed-on: https://chromium-review.googlesource.com/961782
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544968}
[modify] https://crrev.com/52327b7c8438e37862cd935304006b39f88f5b41/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/52327b7c8438e37862cd935304006b39f88f5b41/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
[modify] https://crrev.com/52327b7c8438e37862cd935304006b39f88f5b41/chrome/browser/resources/chromeos/wallpaper_manager/js/util.js
[modify] https://crrev.com/52327b7c8438e37862cd935304006b39f88f5b41/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js
[modify] https://crrev.com/52327b7c8438e37862cd935304006b39f88f5b41/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/52327b7c8438e37862cd935304006b39f88f5b41/chrome/browser/resources/chromeos/wallpaper_manager/main.html
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6156245e15ba50a715fe110cbfb10128b3706ab4

commit 6156245e15ba50a715fe110cbfb10128b3706ab4
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jun 14 00:01:38 2018

cros: Change the position of current wallpaper info bar

There's updated spec that moves the position of the current wallpaper
info bar to the top of the image list.

https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

Bug:  824453 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I414fb92f75f5b2ffa1b6b732c9be577ed4838107
Reviewed-on: https://chromium-review.googlesource.com/1083138
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567053}
[modify] https://crrev.com/6156245e15ba50a715fe110cbfb10128b3706ab4/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
[modify] https://crrev.com/6156245e15ba50a715fe110cbfb10128b3706ab4/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js
[modify] https://crrev.com/6156245e15ba50a715fe110cbfb10128b3706ab4/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/6156245e15ba50a715fe110cbfb10128b3706ab4/chrome/browser/resources/chromeos/wallpaper_manager/main.html

Comment 3 by wzang@chromium.org, Jun 23 2018

Status: Fixed (was: Started)
►

Sign in to add a comment