New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824439 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Supersize: Add generated apk to integration_test.py

Project Member Reported by wnwen@chromium.org, Mar 21 2018

Issue description

This will test parsing other files, pak files, and dex files.
 

Comment 1 by wnwen@chromium.org, Mar 26 2018

Status: Started (was: Assigned)
Components: Tools>BinarySize
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17f295181d27feaa4044c3d74f2b64e717e0fdb3

commit 17f295181d27feaa4044c3d74f2b64e717e0fdb3
Author: Peter Wen <wnwen@chromium.org>
Date: Tue Mar 27 03:37:56 2018

Supersize: Record full size for overhead symbols

Currently the size/padding for overhead symbols are lost upon saving and
loading since only size_without_padding is saved, and these symbols have
address 0 and size == padding.

Thus save the full size including padding for overhead symbols and rely
on _CalculatePadding to set padding = size when loading.

Bug:  824439 
Change-Id: I64fc531478ab3875880566075b98451dbc91ab27
Reviewed-on: https://chromium-review.googlesource.com/980779
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545985}
[modify] https://crrev.com/17f295181d27feaa4044c3d74f2b64e717e0fdb3/tools/binary_size/libsupersize/archive.py
[modify] https://crrev.com/17f295181d27feaa4044c3d74f2b64e717e0fdb3/tools/binary_size/libsupersize/file_format.py
[modify] https://crrev.com/17f295181d27feaa4044c3d74f2b64e717e0fdb3/tools/binary_size/libsupersize/models.py
[modify] https://crrev.com/17f295181d27feaa4044c3d74f2b64e717e0fdb3/tools/binary_size/libsupersize/testdata/Archive_Elf.golden
[modify] https://crrev.com/17f295181d27feaa4044c3d74f2b64e717e0fdb3/tools/binary_size/libsupersize/testdata/Archive_Pak.golden
[modify] https://crrev.com/17f295181d27feaa4044c3d74f2b64e717e0fdb3/tools/binary_size/libsupersize/testdata/Console.golden
[modify] https://crrev.com/17f295181d27feaa4044c3d74f2b64e717e0fdb3/tools/binary_size/libsupersize/testdata/Csv.golden
[modify] https://crrev.com/17f295181d27feaa4044c3d74f2b64e717e0fdb3/tools/binary_size/libsupersize/testdata/FullDescription.golden

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7

commit e3e9e4af2dfdcc5470092768b566707c1b7b4bb7
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Mar 28 13:19:57 2018

Supersize: Add generated apk integration test

This exercises pak file parsing, dex file parsing, and all the apk_path
dependent code paths.

Bug:  824439 
Change-Id: Idae56ee6bda7c1bd942c73979ff69e115753bcbc
Reviewed-on: https://chromium-review.googlesource.com/980815
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546469}
[modify] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/archive.py
[modify] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/integration_test.py
[add] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/testdata/Archive_Apk.golden
[rename] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/testdata/Archive_Pak_Files.golden
[rename] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/testdata/mock_apk/assets/en-US.pak
[add] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/testdata/mock_output_directory/build_vars.txt
[add] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/testdata/mock_output_directory/size-info/test.apk.jar.info
[rename] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/testdata/mock_output_directory/size-info/test.apk.pak.info
[add] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/testdata/mock_sdk/tools/bin/apkanalyzer
[add] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/testdata/mock_sdk/tools/bin/apkanalyzer.output
[add] https://crrev.com/e3e9e4af2dfdcc5470092768b566707c1b7b4bb7/tools/binary_size/libsupersize/testdata/mock_sdk/tools/bin/mock_apkanalyzer.py

Comment 5 by wnwen@chromium.org, Mar 28 2018

Status: Fixed (was: Started)

Sign in to add a comment