New issue
Advanced search Search tips

Issue 824432 link

Starred by 1 user
Status: Assigned
Owner:
mdjones@chromium.org
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

Scrim needs to behave differently depending on what triggers it

Project Member Reported by mdjones@chromium.org, Mar 21 2018 
The scrim used to obscure content when the omnibox is focused or when the bottom sheet is opened now needs to behave differently since the bottom sheet and omnibox are now separate.

When the sheet is opened, the scrim needs to cover the omnibox. If the omnibox is focused, the scrim cannot cover it.

Option 1: Use two scrims.
Option 2: Temporarily move the scrim in the hierarchy while the bottom sheet it open.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c4886a5ecaffc57670b792ea179b9ce66756a6c

commit 3c4886a5ecaffc57670b792ea179b9ce66756a6c
Author: Matthew Jones <mdjones@chromium.org>
Date: Mon Mar 26 18:05:15 2018

Move scrim in view hierarchy when bottom sheet is open

The scrim needs to obscure different views depending on which view
triggered it. In the case of the bottom sheet it needs to cover the
top toolbar, but it shouldn't cover the toolbar when the omnibox is
focused.

This change temporarily moved the scrim in the view hierarchy while
the bottom sheet is open so that it covers the top toolbar. When the
sheet is closed, it is moved back to its original position.

BUG=824432

Change-Id: Ic7e462b09aeb02eae51c725dc811eaf66f2d1c6f
Reviewed-on: https://chromium-review.googlesource.com/973889
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545838}
[modify] https://crrev.com/3c4886a5ecaffc57670b792ea179b9ce66756a6c/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/3c4886a5ecaffc57670b792ea179b9ce66756a6c/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetController.java
[modify] https://crrev.com/3c4886a5ecaffc57670b792ea179b9ce66756a6c/ui/android/java/src/org/chromium/ui/UiUtils.java
►

Sign in to add a comment