Deprecate and remove outdated task running API in content's test_utils.h |
|
Issue descriptioncontent/public/test/test_utils.h
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c59d0aeefab2b990941da360840c06e982caa6 commit d4c59d0aeefab2b990941da360840c06e982caa6 Author: Gabriel Charette <gab@chromium.org> Date: Wed Mar 21 20:12:26 2018 Introduce TestBrowserThreadBundle::RunUntilIdle() I'm tired of having to call a static method deep into content/test just to RunUntilIdle. This brings TestBrowserThreadBundle to feature parity with ScopedTaskEnvironment in this space which makes sense as the two are interchangeable. This also comes closer to robliao's goal of getting rid of TaskScheduler::FlushForTesting() (used by content::RunAllTasksUntilIdle()). And lastly, it makes cleanups in crbug.com/823797 less ugly as some of them will need to go from using a ScopedTaskEnvironment to a TestBrowserThreadBundle and reverting them back to static global flush is ugly. R=jam@chromium.org, robliao@chromium.org Bug: 823797 , 824431 Change-Id: I9f3127f3e46a520fd2d7105ed8139f1046cb3f73 Reviewed-on: https://chromium-review.googlesource.com/971821 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544819} [modify] https://crrev.com/d4c59d0aeefab2b990941da360840c06e982caa6/content/public/test/test_browser_thread_bundle.cc [modify] https://crrev.com/d4c59d0aeefab2b990941da360840c06e982caa6/content/public/test/test_browser_thread_bundle.h [modify] https://crrev.com/d4c59d0aeefab2b990941da360840c06e982caa6/content/public/test/test_browser_thread_bundle_unittest.cc [modify] https://crrev.com/d4c59d0aeefab2b990941da360840c06e982caa6/content/public/test/test_utils.h
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/147335eab3969668ade363f4f87985d75cfe34eb commit 147335eab3969668ade363f4f87985d75cfe34eb Author: Gabriel Charette <gab@chromium.org> Date: Thu Mar 22 15:59:19 2018 Deprecate content's test_utils.h APIs for task running in favor of modern task running APIs. And introduce TestBrowserThreadBundle::RunIOThreadUntilIdle() to replace the only method that didn't have an immediate replacement. Bug: 824431 Change-Id: I2137660a745491d6096ef7f2e3d76818d2a9fa8e Reviewed-on: https://chromium-review.googlesource.com/974166 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#545099} [modify] https://crrev.com/147335eab3969668ade363f4f87985d75cfe34eb/PRESUBMIT.py [modify] https://crrev.com/147335eab3969668ade363f4f87985d75cfe34eb/content/public/test/test_browser_thread_bundle.cc [modify] https://crrev.com/147335eab3969668ade363f4f87985d75cfe34eb/content/public/test/test_browser_thread_bundle.h [modify] https://crrev.com/147335eab3969668ade363f4f87985d75cfe34eb/content/public/test/test_browser_thread_bundle_unittest.cc [modify] https://crrev.com/147335eab3969668ade363f4f87985d75cfe34eb/content/public/test/test_utils.h
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d48c03c8edf8026b802e754d6f2dad9ac7fbcca4 commit d48c03c8edf8026b802e754d6f2dad9ac7fbcca4 Author: Gabriel Charette <gab@chromium.org> Date: Fri May 11 15:28:24 2018 [Documentation] RunAllTasksUntilIdle() is still useful in browser tests. Deprecating was a bit too strong as this is still useful in few browser tests (which don't have TestBrowserThreadBundle since it's a unit test construct). R=jam@chromium.org Bug: 824431 Change-Id: Id1b44632aca4f02cbf579fe3fb2b0a91c2ac0ba4 Reviewed-on: https://chromium-review.googlesource.com/1054632 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557888} [modify] https://crrev.com/d48c03c8edf8026b802e754d6f2dad9ac7fbcca4/content/public/test/test_utils.h |
|
►
Sign in to add a comment |
|
Comment 1 by gab@chromium.org
, Mar 21 2018