SyncPointManager spamming error messages |
|
Issue descriptionOn ToT I get a ton of "Client did not release sync token as expected" messages just by doing simple stuff like opening Chrome (instant 10+ errors), interacting with the page, resizing (this is particularly bad), or simply doing nothing (sometimes I get 1 error per second without any sort of interaction with the browser). We should investigate whether this is a serious issue or not, and if it's not we should stop spamming the console.
,
Mar 21 2018
I just noticed that sunnyps@ already has a CL in flight. https://chromium-review.googlesource.com/c/chromium/src/+/969968
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef091c206803ebe507755cb65a1942b097fbeb32 commit ef091c206803ebe507755cb65a1942b097fbeb32 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Wed Mar 21 20:00:01 2018 gpu: Address piman's nits from crrev.com/c/969639 Remove the DCHECK for wait order number, and remove the spammy invalid client wait logging. R=piman BUG=797137,824430 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9bcdcab80c01b708817c31a4d7ad5f5e885226c9 Reviewed-on: https://chromium-review.googlesource.com/969968 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544810} [modify] https://crrev.com/ef091c206803ebe507755cb65a1942b097fbeb32/gpu/command_buffer/service/sync_point_manager.cc |
|
►
Sign in to add a comment |
|
Comment 1 by samans@chromium.org
, Mar 21 2018Labels: OS-Linux