New issue
Advanced search Search tips

Issue 824418 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 817419



Sign in to add a comment

interactive_ui_tests MacViews Sending Keyboard or Mouse Input is Unreliable

Project Member Reported by robliao@chromium.org, Mar 21 2018

Issue description

Sending keyboard or mouse events doesn't seem to consistently work. This might be because focus might be broken too.
 
Labels: MacViews-Browser
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11aa050717f6b6a3838d6a2f24d5876b941bbedf

commit 11aa050717f6b6a3838d6a2f24d5876b941bbedf
Author: Robert Liao <robliao@chromium.org>
Date: Thu Mar 22 12:52:18 2018

Disable MacViews Tests Impacted by Focus and/or Input Issues

BUG=824418

Change-Id: Iab8ded70524c59d50f8c10646df2a3dd3ee71dfe
Reviewed-on: https://chromium-review.googlesource.com/974072
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545050}
[modify] https://crrev.com/11aa050717f6b6a3838d6a2f24d5876b941bbedf/chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc
[modify] https://crrev.com/11aa050717f6b6a3838d6a2f24d5876b941bbedf/chrome/browser/ui/views/keyboard_access_browsertest.cc
[modify] https://crrev.com/11aa050717f6b6a3838d6a2f24d5876b941bbedf/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
[modify] https://crrev.com/11aa050717f6b6a3838d6a2f24d5876b941bbedf/chrome/browser/ui/views/location_bar/star_view_browsertest.cc
[modify] https://crrev.com/11aa050717f6b6a3838d6a2f24d5876b941bbedf/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
[modify] https://crrev.com/11aa050717f6b6a3838d6a2f24d5876b941bbedf/chrome/browser/ui/views/sad_tab_view_interactive_uitest.cc
[modify] https://crrev.com/11aa050717f6b6a3838d6a2f24d5876b941bbedf/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
[modify] https://crrev.com/11aa050717f6b6a3838d6a2f24d5876b941bbedf/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

Labels: Target-68
Owner: robliao@chromium.org
Status: Assigned (was: Available)
MacViews triage: let's target fixing this at M68.
Labels: MacViews-Tests

Comment 5 by gov...@chromium.org, Apr 13 2018

Labels: Proj-MacViews
Labels: M-68
Labels: Sprint-1

Comment 8 by gov...@chromium.org, Apr 25 2018

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
Labels: Sprint-2
Can we remove "Sprint-1" label as "Sprint-2" is already applied at #9?
Labels: -Sprint-1
Removing "Sprint-1" label per https://bugs.chromium.org/p/chromium/issues/detail?id=712244#c11.
Any progress here?
This will likely not be done by the end of Sprint 2.
Cc: ellyjo...@chromium.org
Thank you for the update robliao@.


M68 branch is coming soon on this Thursday, 05/24 and M68 Beta promotion is on 06/07. 
This bug is marked as P1 for M68. Pls land the fix to trunk ASAP (if possible before 4:00 PM PT this Thursday in order to make it to M68 branch build cut. Thank you.
Labels: -Pri-1 Pri-2
This only has test impact. Adjusting to P2.
Labels: -Target-68 Target-69
Labels: -M-68 Group-Tests
Labels: M-68
Labels: -M-68 M-69
Labels: -M-69 -Target-69 M-70 Target-70
Tests verified still broken here:
LocationIconViewTest.HideOnSecondClick
StarViewTest.HideOnSecondClick
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94

commit 3fd4d13e696ecb0568552b9ae12b941c1dbd5b94
Author: Peter Kasting <pkasting@chromium.org>
Date: Fri Nov 16 21:36:47 2018

Re-enable two disabled tests in c/b/ui/views/location_bar/.

This updates the comments on the other tests to have TODO form.

Bug: 163931, 823543, 824418
Change-Id: Ic82109fb4513a6b8053477ac28e5ee3969799f52
Reviewed-on: https://chromium-review.googlesource.com/c/1334842
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608959}
[modify] https://crrev.com/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
[modify] https://crrev.com/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94/chrome/browser/ui/views/location_bar/star_view_browsertest.cc
[modify] https://crrev.com/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc6204209f6b627ac9b3040c6be34c8506b8a52

commit 1dc6204209f6b627ac9b3040c6be34c8506b8a52
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Nov 27 23:48:41 2018

Fix and re-enable disabled tests in c/b/ui/views/omnibox/.

These pass on Windows.

Bug: 824418, 905508
Change-Id: Ib6420284643a430cc43a76de3afbb5c2e3de6099
Reviewed-on: https://chromium-review.googlesource.com/c/1333119
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611421}
[modify] https://crrev.com/1dc6204209f6b627ac9b3040c6be34c8506b8a52/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc
[modify] https://crrev.com/1dc6204209f6b627ac9b3040c6be34c8506b8a52/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 17 (6 days ago)

Sign in to add a comment