New issue
Advanced search Search tips

Issue 824389 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 653200



Sign in to add a comment

Preserve order of frames if GpuMemoryBufferVideoFramePool returns early

Project Member Reported by emir...@chromium.org, Mar 21 2018

Issue description

In case of a frame that returns early from GpuMemoryBufferVideoFramePool, we might break the sequence as they are returned immediately. It should work in FIFO order.
 
Status: Assigned (was: Untriaged)
Blocking: 653200
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/553c236ee5102adb14f3b324a3894f8eab2b3af5

commit 553c236ee5102adb14f3b324a3894f8eab2b3af5
Author: Emircan Uysaler <emircan@chromium.org>
Date: Fri Mar 23 00:13:47 2018

Preserve order of frames when GpuMemoryBufferVideoFramePool returns early

This CL tries to force FIFO order for GpuMemoryBufferVideoFramePool input and
output. It refactors StartCopy() to reflect that it is currently working on the
first element only. It puts invalid tasks to the queue and marks them. When we
come across to the mark, we return them and continue with next tasks.

Bug:  824389 
Change-Id: Id4afcd01aca9f4414781b9b446fb0f429ecb94e9
Reviewed-on: https://chromium-review.googlesource.com/974129
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545299}
[modify] https://crrev.com/553c236ee5102adb14f3b324a3894f8eab2b3af5/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/553c236ee5102adb14f3b324a3894f8eab2b3af5/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment