Enforce early release of StaticBitmapImage->SkImage in dtors |
|
Issue descriptionAccording to what was observed in crbug.com/823260 , if a class or struct contains a std::unique_ptr<StaticBitmapImage> member, we need to make sure that we set the member to nullptr in its dtor to enforce early release of the backing SkImage. Everything might be fine. This bug is filed to do a double check.
,
Mar 22 2018
This is not what is going on. Your CL https://chromium-review.googlesource.com/c/chromium/src/+/973554 did not add anything to the destructor. It's the Dispose() method. That is a very different thing. For garbage collected types, destruction is controlled by the garbage collector. There are cases where we know that an object is finished doing its job ahead of destruction, that is when we call Dispose(). The idea is to free non- garbage collected resources *ahead* of GC. |
|
►
Sign in to add a comment |
|
Comment 1 by zakerinasab@chromium.org
, Mar 22 2018