Concierge is now the preferred method of launching VMs. Remove vm_launcher and any code invoking it.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c23f3a071fbc54343fa7bb11a9c87d7756f167ea commit c23f3a071fbc54343fa7bb11a9c87d7756f167ea Author: Stephen Barber <smbarber@chromium.org> Date: Fri Mar 23 01:16:54 2018 login: remove termina manager and associated code vm_launcher is deprecated in favor of concierge. crosh has already been converted to invoke concierge, so this code can be safely removed. BUG= chromium:824387 TEST=unittests Change-Id: I184316bbbe2a302734a359d27d3d0c8daa3ecabf Reviewed-on: https://chromium-review.googlesource.com/973804 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [delete] https://crrev.com/e05946b652b0c85fa7e0e9e384b07d580ebb4971/login_manager/termina_manager_impl.h [delete] https://crrev.com/e05946b652b0c85fa7e0e9e384b07d580ebb4971/login_manager/termina_manager_interface.h [delete] https://crrev.com/e05946b652b0c85fa7e0e9e384b07d580ebb4971/login_manager/fake_termina_manager.h [modify] https://crrev.com/c23f3a071fbc54343fa7bb11a9c87d7756f167ea/login_manager/session_manager_service.h [delete] https://crrev.com/e05946b652b0c85fa7e0e9e384b07d580ebb4971/login_manager/termina_manager_impl.cc [modify] https://crrev.com/c23f3a071fbc54343fa7bb11a9c87d7756f167ea/login_manager/session_manager_service.cc [modify] https://crrev.com/c23f3a071fbc54343fa7bb11a9c87d7756f167ea/login_manager/SessionManager.conf [modify] https://crrev.com/c23f3a071fbc54343fa7bb11a9c87d7756f167ea/login_manager/session_manager_impl.h [modify] https://crrev.com/c23f3a071fbc54343fa7bb11a9c87d7756f167ea/login_manager/session_manager_impl.cc [modify] https://crrev.com/c23f3a071fbc54343fa7bb11a9c87d7756f167ea/login_manager/dbus_bindings/org.chromium.SessionManagerInterface.xml [modify] https://crrev.com/c23f3a071fbc54343fa7bb11a9c87d7756f167ea/login_manager/session_manager_impl_unittest.cc [modify] https://crrev.com/c23f3a071fbc54343fa7bb11a9c87d7756f167ea/login_manager/login_manager.gyp [delete] https://crrev.com/e05946b652b0c85fa7e0e9e384b07d580ebb4971/login_manager/fake_termina_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/691d848fd5a0747c8464ec5de1e4e0a81a80f7fa commit 691d848fd5a0747c8464ec5de1e4e0a81a80f7fa Author: Stephen Barber <smbarber@chromium.org> Date: Fri Mar 23 21:50:59 2018 vm_tools: remove vm_launcher binary BUG= chromium:824387 TEST=emerge-eve vm_tools CQ-DEPEND=CL:973804 Change-Id: I796514c9dd4f59163f03546f02f18a6c79f2b697 Reviewed-on: https://chromium-review.googlesource.com/973751 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/691d848fd5a0747c8464ec5de1e4e0a81a80f7fa/chromeos-base/vm_tools/vm_tools-9999.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/65239b61aa3bfc36205f21e9b8b24bcfb0377f06 commit 65239b61aa3bfc36205f21e9b8b24bcfb0377f06 Author: Stephen Barber <smbarber@chromium.org> Date: Mon Mar 26 21:41:26 2018 vm_tools: remove vm_launcher With the login manager code invoking vm_launcher gone, there are no remaining clients of vm_launcher. Remove the binary. BUG= chromium:824387 TEST=emerge-eve vm_tools CQ-DEPEND=CL:973751 Change-Id: Ib73f63a1c179a76e8b120441d49bf1893afee51c Reviewed-on: https://chromium-review.googlesource.com/973805 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/65239b61aa3bfc36205f21e9b8b24bcfb0377f06/vm_tools/host.gypi [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/pooled_resource.h [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/crosvm.h [modify] https://crrev.com/65239b61aa3bfc36205f21e9b8b24bcfb0377f06/vm_tools/docs/logging.md [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/subnet.h [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/README.md [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/mac_address.h [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/constants.h [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/vsock_cid.cc [modify] https://crrev.com/65239b61aa3bfc36205f21e9b8b24bcfb0377f06/vm_tools/proto/vm_host.proto [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/nfs_export.cc [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/nfs_export.h [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/vsock_cid.h [modify] https://crrev.com/65239b61aa3bfc36205f21e9b8b24bcfb0377f06/vm_tools/README.md [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/vm_launcher.cc [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/crosvm.cc [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/pooled_resource.cc [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/mac_address.cc [delete] https://crrev.com/9771ca33c7ff7601929b87ca8c992e1d0e3cde9e/vm_tools/launcher/subnet.cc
Good night, sweet code.
Comment 1 by bugdroid1@chromium.org
, Mar 23 2018