New issue
Advanced search Search tips

Issue 824378 link

Starred by 1 user
Status: Assigned
Owner:
stkhapugin@chromium.org
Cc:
justincohen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use PAGE_TRANSITION_GENERATED for voice search and non-URL omnibox queries

Project Member Reported by kkhorimoto@chromium.org, Mar 21 2018 
The comments for this transition type are:

  // User got to this page by typing in the URL bar and selecting an entry
  // that did not look like a URL.  For example, a match might have the URL
  // of a Google search result page, but appear like "Search Google for ...".
  // These are not quite the same as TYPED navigations because the user
  // didn't type or see the destination URL.

From this description, it seems that we should be using the GENERATED transition type for non-URL queries originating from LocationBarCoordinator.  However, I'm not sure how this transition type is used, or what possible side effects may result from updating the transition type of queries that go through LocationBarCoordinator's |-loadURLForQuery:|.

Comment 1 by mpear...@chromium.org, Mar 21 2018 

Yes, for voice search you should be using PAGE_TRANSITION_GENERATED.

For anything selected from the omnibox, you shouldn't have to think about this at all.  You should be using the selected AutocompleteMatch's transition field.
  // The transition type to use when the user opens this match.  By default
  // this is TYPED.  Providers whose matches do not look like URLs should set
  // it to GENERATED.
  ui::PageTransition transition;
https://cs.chromium.org/chromium/src/components/omnibox/browser/autocomplete_match.h?type=cs&q=transition&l=414
►

Sign in to add a comment