New issue
Advanced search Search tips

Issue 824375 link

Starred by 2 users
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: Apr 2018
Cc:
bsheedy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression
Proj-VR
Proj-XR



Sign in to add a comment

VR Overflow menu-induced rendering regressions

Project Member Reported by bsheedy@google.com, Mar 21 2018 
It looks like the addition of the VR overflow menu (https://chromium-review.googlesource.com/c/chromium/src/+/967256) caused a number of draw_* and update_* regressions. This is probably unavoidable since we're adding new UI, but it'll be good to double check that.

The memory regressions in the same regression range are likely related, but that has yet to be confirmed.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 21 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=824375

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=2c83f752fa71e76475a6dab43acb81fa17493bfa2b77c1a4cbbc36e161f0e6ab


Bot(s) for this bug's original alert(s):

pixel_xl

Comment 2 by bsheedy@chromium.org, Mar 21 2018

Components: Internals>VR
Labels: VR-Perf OS-Android

Comment 3 by bsheedy@chromium.org, Mar 22 2018 

Memory regressions confirmed to be caused by the overflow menu, as well.

Comment 4 by cjgrant@chromium.org, Mar 24 2018

Labels: -M-67 M-68
As mentioned, I think the regressions aren't regressions, but simply the overhead of adding more UI.  I think we should assess where we are with performance (as a whole) after M-67.  Right now, it's not an issue (although it's good to have these metrics to catch unnaturally large increases).  Changing to M-68.

Comment 5 by cjgrant@chromium.org, Apr 16 2018

Status: Fixed (was: Assigned)
Closing, as per the recent performance scrub.  We improved performance in many regards, and should now be less subject to the impact of new (unshown) UI.

Comment 6 by dougman@chromium.org, Apr 16 2018

Labels: Test-Complete

Comment 7 by btebbs@chromium.org, Jul 4

Components: Internals>XR
►

Sign in to add a comment