New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824374 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

[VR Browsing] Leave site? changes may not be saved, 2D prompt appears

Project Member Reported by dbbrooks@chromium.org, Mar 21 2018

Issue description

Chrome Version: 67.0.3376.0
OS:Android N
VRCore: 1.13.185188193
Device: Pixel

What steps will reproduce the problem?
(1) Enter VR browsing and go to https://m.facebook.com/r.php
(2) start typing some text in the first name field
(3) Click the back button in the omnibox

What is the expected result? 2D popup UI rendered in VR browsing or suppressed.

What happens instead? 2D popup appears breaking VR experience.See screenshot.

Side note: we may want to add a manual test case for this popup.
 
Screenshot_20180321-101102.png
240 KB View Download
Cc: asimjour@chromium.org ymalik@chromium.org
Labels: M-67 OS-Android Pri-1
Status: ericdechromium.org (was: Untriaged)
@ericde, could you please take a look and update the priority.
I think, we should disable this or support it for 67.

Comment 2 by ericde@google.com, Mar 23 2018

Cc: mthiesse@chromium.org
Labels: Hotlist-VRB-MVP
Status: Available (was: ericdechromium.org)

Comment 3 by ericde@google.com, Mar 23 2018

Labels: Type-Bug

Comment 4 by bshe@chromium.org, Apr 6 2018

Owner: bshe@chromium.org
Status: Assigned (was: Available)
taking this one given that it is p1 and mvp and no owner yet.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cabb926c4c89c2e9db968bee2c552cf6ff0c96d

commit 9cabb926c4c89c2e9db968bee2c552cf6ff0c96d
Author: Biao She <bshe@chromium.org>
Date: Sat Apr 07 03:39:08 2018

Fix before unload dialog for VR

The dialog was still showing as a 2D UI. This CL makes it appears correctly in VR.

Bug:  824374 
Change-Id: I7363e0988427de9b5434bc1c436816fa9b597ad8
Reviewed-on: https://chromium-review.googlesource.com/1000433
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549028}
[modify] https://crrev.com/9cabb926c4c89c2e9db968bee2c552cf6ff0c96d/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java

Comment 6 by bshe@chromium.org, Apr 9 2018

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Comment 8 Deleted

Sign in to add a comment