New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824212 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 634542



Sign in to add a comment

Use SkColorSpace::isSRGB() instead of SkColorSpace::Equals()

Project Member Reported by zakerinasab@chromium.org, Mar 21 2018

Issue description

Since SkColorSpace now has a isSRGB() member, we can replace SkColorSpace::Equals(SkColorSpace::MakeSRGB().get(), color_space) with color_space->isSRGB().
 
Blocking: 634542
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/446aac41da0bc01666cfe6f3c4ca2d728ee6cb38

commit 446aac41da0bc01666cfe6f3c4ca2d728ee6cb38
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Thu Apr 26 19:24:33 2018

Remove SkColorSpace::Equals(sRGB)

Since SkColorSpace now has a isSRGB() member, we can replace
SkColorSpace::Equals(SkColorSpace::MakeSRGB().get(), color_space)
with color_space->isSRGB().

Bug:  824212 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I50e88d4295e3830db75d9a6970791790473d14e2
Reviewed-on: https://chromium-review.googlesource.com/1030778
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554116}
[modify] https://crrev.com/446aac41da0bc01666cfe6f3c4ca2d728ee6cb38/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/446aac41da0bc01666cfe6f3c4ca2d728ee6cb38/third_party/blink/renderer/platform/graphics/canvas_color_params.cc

Status: Fixed (was: Assigned)

Sign in to add a comment