New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824208 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Rename CONFIG_USB_PD_TCPM_ANX74XX to CONFIG_USB_PD_TCPM_ANX3429

Project Member Reported by jettrink@chromium.org, Mar 21 2018

Issue description

Since every use of the CONFIG_USB_PD_TCPM_ANX74XX is actually using the ANX3429 chip, we should rename it to match. Also there is a new driver for the ANX7447 chip that does not use the ANX74XX driver.
 
I agree with what you said
lilbroomstick.jpeg
4.1 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/ca204befd3c9365950cbb9336f0b71bd42c1047a

commit ca204befd3c9365950cbb9336f0b71bd42c1047a
Author: Jett Rink <jettrink@chromium.org>
Date: Fri Mar 23 21:50:51 2018

tcpc: rename CONFIG_USB_PD_TCPM_ANX74XX to CONFIG_USB_PD_TCPM_ANX3429

Since all of the uses of CONFIG_USB_PD_TCPM_ANX74XX are actually for
ANX3429, rename the option especially since the ANX7447
driver will not reuse the ANX74XX driver which is being introduced
in CL:956790.

Also adding the CONFIG_USB_PD_TCPM_ANX740X and
CONFIG_USB_PD_TCPM_ANX741X options to advertise which versions of the
ANX chip the anx74xx.c driver applies to.

BRANCH=none
BUG= chromium:824208 
TEST=build all

Change-Id: Ib47f4661466e54ff2a0c52d517eb318d3bfd25a2
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/973558
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>

[modify] https://crrev.com/ca204befd3c9365950cbb9336f0b71bd42c1047a/board/coral/board.h
[modify] https://crrev.com/ca204befd3c9365950cbb9336f0b71bd42c1047a/board/eve/board.h
[modify] https://crrev.com/ca204befd3c9365950cbb9336f0b71bd42c1047a/board/yorp/board.h
[modify] https://crrev.com/ca204befd3c9365950cbb9336f0b71bd42c1047a/board/poppy/board.h
[modify] https://crrev.com/ca204befd3c9365950cbb9336f0b71bd42c1047a/board/grunt/board.h
[modify] https://crrev.com/ca204befd3c9365950cbb9336f0b71bd42c1047a/driver/build.mk
[modify] https://crrev.com/ca204befd3c9365950cbb9336f0b71bd42c1047a/driver/tcpm/tcpci.c
[modify] https://crrev.com/ca204befd3c9365950cbb9336f0b71bd42c1047a/include/config.h
[modify] https://crrev.com/ca204befd3c9365950cbb9336f0b71bd42c1047a/board/reef/board.h

Components: OS>Firmware>EC
Labels: OS-Chrome
Status: Verified (was: Started)

Sign in to add a comment