We want to be able to show permission status when entering VR (or when requested) and to accept permissions while in VR.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d648ee17fe010d262c447a3585e6227982532c68 commit d648ee17fe010d262c447a3585e6227982532c68 Author: Ian Vollick <vollick@chromium.org> Date: Fri Mar 23 16:38:24 2018 [vr] show permission indicators when entering vr With this change we show indicators describing what is being captured when entering VR presentation. It also includes a revamp of the "press app button to exit" UI. Bug: 824187 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic302b8196d081044aa92da655553984d4da22074 Reviewed-on: https://chromium-review.googlesource.com/973687 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#545481} [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/app/generated_resources.grd [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/browser_ui_interface.h [add] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/elements/indicator_spec.cc [add] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/elements/indicator_spec.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/elements/ui_element_name.h [add] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/model/capturing_state_model.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/model/capturing_state_model.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/model/color_scheme.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/model/web_vr_model.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/test/mock_browser_ui_interface.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/ui.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/ui.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/ui_unittest.cc [modify] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/vector_icons/BUILD.gn [add] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/vector_icons/my_location.icon [add] https://crrev.com/d648ee17fe010d262c447a3585e6227982532c68/chrome/browser/vr/vector_icons/remove_circle_outline.icon
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cf746ceac082ac80d39a917e998f4a33d6a1a0b commit 1cf746ceac082ac80d39a917e998f4a33d6a1a0b Author: Ian Vollick <vollick@chromium.org> Date: Fri Mar 23 22:17:25 2018 [vr] Update system indicator UX This updates the system indicators to match the spec. When hovered, a tooltip appears with details. Bug: 824187 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie5c44bb0e448febe4c253d6ce91a0b43aad50535 Reviewed-on: https://chromium-review.googlesource.com/978614 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545592} [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/app/generated_resources.grd [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/browser_ui_interface.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/disc_button.cc [add] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/oval.cc [add] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/oval.h [add] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/oval_unittest.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/rect.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/toast.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/ui_element_type.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/ui_element_type.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/elements/vector_icon_button.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/model/color_scheme.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/test/mock_browser_ui_interface.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/testapp/vr_test_context.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/ui.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/ui.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/1cf746ceac082ac80d39a917e998f4a33d6a1a0b/chrome/browser/vr/ui_unittest.cc
Verified in build 67.0.3389.0 canary. Looks good. Tests have been added to cover both VR Browsing and WebVR to the Manual Test Plan.
Comment 1 by vollick@chromium.org
, Mar 21 2018