Untitled title is displayed for newtab on opening a download url link in newtab |
|||||||||
Issue descriptionApp Version: 67.0.3376.0 Canary iOS Version: 10.3.3, 11.2.6 Device : iPad Air 2, iPad Mini2 URL: https://developer.apple.com/fonts/ https://www.barebones.com/products/bbedit/download.html Steps to reproduce: 1. Launch chrome in Normal Mode. 2. Goto https://developer.apple.com/fonts/ 3. Long Tap on Download button. 4. Tap on Open in Newtab in context menu. 5. Tap on Tab Switcher and navigate to newtab. 6. Tap on tabswithcer in newly opened tab Observed results: Tab name is displayed as Untitled Expected results: Url should be displayed for tab name Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on current stable build (App Version, iOS Version): No on M65 [New Download UI from M67] Bug reproducible on the current beta channel build (App Version, iOS Version): No on M66 [New Download UI from M67] Video : New UI : https://drive.google.com/file/d/1XVoODZpTydWpflxN6WVvDZkoseVA49s-/view?usp=sharing Old Ui : https://drive.google.com/file/d/12dPcRkAmtWjm_sNJwoddhdVtl6H16GGg/view?usp=sharing
,
Mar 21 2018
This is a minor bug, which should not block the release.
,
Mar 22 2018
Tab tile represent the title of currently displayed web page. In the old Download Manager, download UI was a web page, so we displayed the URL as a title. In the new download manager, the download UI is decoupled from the web page. So page title has nothing to do with download URL. The blank page has default title, which is Untitled. So I think this is WAI. Khalil, Gabe what do you think?
,
Mar 26 2018
Closing as WAI. Please reopen if you disagree.
,
Apr 5 2018
I tried this in the new tab switcher UI that's in Canary. It looks odder there since the tab doesn't say "Untitled." It just has not title at all (see screenshot attached). I'm wondering whether this can instead be given a generic title like "Download" that reminds the user of the context of this tab. Either way, I agree this is a minor bug and isn't a blocker for the release.
,
Apr 5 2018
Khalil, WDYT about Gabe's proposal?
,
Apr 6 2018
Agreed. Let's show "Untitled".
,
Apr 6 2018
Khalil just agreed offline that "Download" is more indicative than "Untitled"
,
Apr 6 2018
Ok, it should be possible to use "Download" if web page does not have any navigation items and Download UI is displayed.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3a6034a65b11598d1dfa714b88449dc36ba3641 commit d3a6034a65b11598d1dfa714b88449dc36ba3641 Author: Eugene But <eugenebut@google.com> Date: Wed Apr 11 17:17:04 2018 Discard download pending items and stop the load. Omnibox should display the URL for the currently rendered page (about:blank), not download URL. Also added StopLoading call to hide the progress indicator. Bug: 831334 , 824148 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I47eddd9ef7a46480383a60a1425f2c69513cf129 Reviewed-on: https://chromium-review.googlesource.com/1005893 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#549916} [modify] https://crrev.com/d3a6034a65b11598d1dfa714b88449dc36ba3641/ios/web/web_state/navigation_and_load_callbacks_inttest.mm [modify] https://crrev.com/d3a6034a65b11598d1dfa714b88449dc36ba3641/ios/web/web_state/ui/crw_web_controller.mm
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/077e0bc0e138b80bfc79d1a0afaa017469b1761c commit 077e0bc0e138b80bfc79d1a0afaa017469b1761c Author: Eugene But <eugenebut@google.com> Date: Wed Apr 11 22:35:26 2018 Use 'Download' title for empty Download Tabs. Tabs which don't have any navigation items and display Download Manager UI will be special cased to show 'Download' title, instead of 'Untitled' Bug: 824148 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If781b5b1aadfaa6ee7eb2181d0f3222bfb812705 Reviewed-on: https://chromium-review.googlesource.com/1006036 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#549958} [modify] https://crrev.com/077e0bc0e138b80bfc79d1a0afaa017469b1761c/components/new_or_sad_tab_strings.grdp [modify] https://crrev.com/077e0bc0e138b80bfc79d1a0afaa017469b1761c/ios/chrome/browser/download/download_manager_tab_helper.h [modify] https://crrev.com/077e0bc0e138b80bfc79d1a0afaa017469b1761c/ios/chrome/browser/download/download_manager_tab_helper_unittest.mm [modify] https://crrev.com/077e0bc0e138b80bfc79d1a0afaa017469b1761c/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/077e0bc0e138b80bfc79d1a0afaa017469b1761c/ios/chrome/browser/tabs/tab.mm
,
Apr 11 2018
,
Apr 17 2018
Verified in: App Version: 68.0.3398.0 canary Devices: iPhone 7, iPhone X, iPad Air iOS Versions: 10.3.3, 11.4 beta 1 'Download' title is displayed for tabs with Download Manager UI. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by justincohen@chromium.org
, Mar 21 2018Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)