Canvas fill adds extra point to the shape.
Reported by
ivan.pop...@gmail.com,
Mar 21 2018
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36 Steps to reproduce the problem: 1. Add js file to the page 2. Look at the result alternative: Open https://jsfiddle.net/mswqq9fg/32/ What is the expected behavior? Green square in the middle of red square What went wrong? Extra moveTo() adds a point to green rectangle. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 64.0.3282.186 Channel: n/a OS Version: 10.0 Flash Version: Try move the extra point around. Try add one more extra point. Try reduce canvas size to 256x256 and see that bug disappears.
,
Apr 6 2018
Unable to reproduce the issue on Win-10 using chrome stable version #65.0.3325.181 and latest canary #67.0.3390.0. Attached a screen shot for reference. Following are the steps followed to reproduce the issue. ------------ 1. Opened https://jsfiddle.net/mswqq9fg/32/ 2. Observed a green square in the middle of red square as expected. reporter@ - Could you please check the issue on latest stable version #65.0.3325.181 by creating a new profile without any apps and extensions and please let us know if the issue still persist or not. Thanks...!!
,
Apr 6 2018
Problem appears on yours screenshot. Green square is not in the middle. Please comment line "context.moveTo(10, 10); // this point is added to rectangle somehow" commenting this line should give no effect, but it does. Addetional moveto drives render crazy.Attached screen with image that should be with "context.moveTo(10, 10);" commented or not. Thanks
,
Apr 6 2018
Additional example: https://jsfiddle.net/mswqq9fg/90/ The bug is here: https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkPath.cpp?q=skpath&sq=package:chromium&dr=CSs&l=447 isRectContour does not track the first point of the rect I dont know whether to patch this method or rewrite it, there are too many hacks already.
,
Apr 6 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 9 2018
ivan.popelyshev@ Thanks for the feedback. Able to reproduce the issue on Mac OS 10.13.3 and Windows 10 on the latest Canary 67.0.3387.0 and Stable 65.0.3325.181 as per comment #3 & #4. Issue is not observed on Ubuntu 14.04. Attached are the screen shots for reference. This is a Non-Regression issue as this behavior is observed from M60 Chrome builds. Hence marking this as Untriaged for further updates from Dev. Thanks..
,
Apr 9 2018
+caryclark, who is the author of most of the isRectContour code.
,
Apr 9 2018
tracking root bug at skbug.com/7792
,
Apr 10 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/5c715188470e97e4f573ffe78b7ee9451aaa7612 commit 5c715188470e97e4f573ffe78b7ee9451aaa7612 Author: Cary Clark <caryclark@skia.org> Date: Tue Apr 10 11:53:53 2018 fix path to rect when missing close verb R=brianosman@google.com,robertphillips@google.com TBR=reed@google.com Bug: 824145 , skia:7792 Change-Id: I24f121cfa7d437c95b94bd917d3c4888a10c519e Reviewed-on: https://skia-review.googlesource.com/119569 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/5c715188470e97e4f573ffe78b7ee9451aaa7612/tests/PathTest.cpp [modify] https://crrev.com/5c715188470e97e4f573ffe78b7ee9451aaa7612/include/core/SkPath.h [modify] https://crrev.com/5c715188470e97e4f573ffe78b7ee9451aaa7612/src/core/SkPath.cpp
,
Apr 10 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/58627cb8eb559670b86f06225eb87e6c1c5e8504 commit 58627cb8eb559670b86f06225eb87e6c1c5e8504 Author: Cary Clark <caryclark@google.com> Date: Tue Apr 10 14:17:21 2018 one more path is rect bug Add a check to see that the close path generated line is horizontal or vertical when determining that path is a rect. Also change several tests to defer their initialization to reduce debugging interference. R=brianosman@google.com,robertphillips@google.com Bug: 824145 , skia:7792 Change-Id: I4a081ee4ffd3558b499a7a1aede2d6232059715e Reviewed-on: https://skia-review.googlesource.com/120081 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Cary Clark <caryclark@google.com> [modify] https://crrev.com/58627cb8eb559670b86f06225eb87e6c1c5e8504/tests/PathTest.cpp [modify] https://crrev.com/58627cb8eb559670b86f06225eb87e6c1c5e8504/src/core/SkPath.cpp [modify] https://crrev.com/58627cb8eb559670b86f06225eb87e6c1c5e8504/samplecode/SampleDither.cpp [modify] https://crrev.com/58627cb8eb559670b86f06225eb87e6c1c5e8504/samplecode/SampleAARects.cpp [modify] https://crrev.com/58627cb8eb559670b86f06225eb87e6c1c5e8504/gm/shapes.cpp [modify] https://crrev.com/58627cb8eb559670b86f06225eb87e6c1c5e8504/samplecode/SampleColorFilter.cpp
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f670615082257324fbe0105e7461803ae10cc942 commit f670615082257324fbe0105e7461803ae10cc942 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Apr 11 09:31:33 2018 Roll src/third_party/skia/ 1eeeae049..ff7fa50f0 (21 commits) https://skia.googlesource.com/skia.git/+log/1eeeae0491ba..ff7fa50f0c95 $ git log 1eeeae049..ff7fa50f0 --date=short --no-merges --format='%ad %ae %s' 2018-04-10 egdaniel Add ctor to GrVkImageInfo. 2018-04-10 liyuqian Merge drawDevice and respect ctm for the paint 2018-04-10 mtklein skcms→dff16bc express ApproximateCurve error in input units 2018-04-10 csmartdalton ccpr: Clip quadratic hulls more efficiently 2018-04-10 mtklein allow rolling from anywhere 2018-04-10 jvanverth Add initial support for simple concave shadows. 2018-04-10 mtklein skcms→9ff49a5 use GaussNewton for 7-parameter approx 2018-04-06 liyuqian Do not use CTM for drawDevice or drawSprite 2018-04-10 csmartdalton ccpr: Improve CPU checks for collinear points 2018-04-10 csmartdalton ccpr: Remove fCurrAnchorPoint from GrCCGeometry 2018-04-10 mtklein give skcms rolls a helpful commit msg 2018-04-08 update-skps Update SKP version 2018-04-10 robertphillips Remove extra Vulkan submitCommandBuffer from deleteTestingOnlyBackendTexture 2018-04-10 mtklein hard-roll skcms into Skia 2018-04-10 egdaniel Update getBackendInfo calls on GrBackendTexture to support VkImageLayout better. 2018-04-10 caryclark one more path is rect bug 2018-04-09 caryclark fix path to rect when missing close verb 2018-04-09 benjaminwagner Omit skbug6653 on internal device. 2018-04-09 brianosman Remove SkDEBUGFAIL for non-invertible XYZ matrix 2018-04-09 angle-skia-autoroll Roll third_party/externals/angle2/ 6c59e4a15..0ce016c1b (2 commits) 2018-04-06 reed identify interesting cubic points Created with: roll-dep src/third_party/skia BUG= chromium:824145 , chromium:824145 , chromium:819192 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: If3760ced34d61fa366b7363a499b2fe04a8a450a Reviewed-on: https://chromium-review.googlesource.com/1005807 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549839} [modify] https://crrev.com/f670615082257324fbe0105e7461803ae10cc942/DEPS
,
Apr 11 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/8540e110f91df1b1596bd66711e5ad908de1888a commit 8540e110f91df1b1596bd66711e5ad908de1888a Author: Cary Clark <caryclark@skia.org> Date: Wed Apr 11 19:13:07 2018 more path is rect bugs More edge cases found; clean up the logic a bit to make more clear where the rectangle points start and stop. R=robertphillips@google.com,brianosman@google.com Bug: 824145 , skia:7792 Change-Id: Ie24dfd1519f30875f44ffac68e20d777490b00b9 Reviewed-on: https://skia-review.googlesource.com/120422 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/8540e110f91df1b1596bd66711e5ad908de1888a/tests/PathTest.cpp [modify] https://crrev.com/8540e110f91df1b1596bd66711e5ad908de1888a/gm/pathfill.cpp [modify] https://crrev.com/8540e110f91df1b1596bd66711e5ad908de1888a/src/core/SkPath.cpp
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ab03fe975c537e4daf31ef51c74553b5aba67ca commit 8ab03fe975c537e4daf31ef51c74553b5aba67ca Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 12 06:59:07 2018 Roll src/third_party/skia/ ff7fa50f0..c6c5eade8 (26 commits) https://skia.googlesource.com/skia.git/+log/ff7fa50f0c95..c6c5eade823a $ git log ff7fa50f0..c6c5eade8 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 fmalita Reland "Fix handling of MaskFilter matrices" 2018-04-11 angle-skia-autoroll Roll third_party/externals/angle2/ 785b20b7a..2dadd1d08 (11 commits) 2018-04-11 benjaminwagner Upgrade Windows Skolo bots. 2018-04-11 reed remove unused/dumb methods from SkRect 2018-04-11 reed Clean-up paints for drawImage (etc.) to enforce that we always ignore stroking and patheffects. 2018-04-11 caryclark more path is rect bugs 2018-04-11 mtklein skcms→9334796 reject non-XYZ/Lab PCS profiles 2018-04-11 liyuqian Revert "Add private fIsBadForDAA bit to SkPath" 2018-04-11 mtklein skcms→56f2a09 add sRGB profile and ApproximatelyEqualProfiles() 2018-04-11 liyuqian Add private fIsBadForDAA bit to SkPath 2018-04-11 robertphillips Add Vulkan to the DDL bots 2018-04-11 mtklein roll to particular targets 2018-04-11 benjaminwagner Switch to latest Windows Intel Skylake GPU driver. 2018-04-11 fmalita Fix SkTCopyOnFirstWrite copy semantics 2018-04-11 reed no need to tile draws that don't involve paths 2018-04-11 mtklein skcms→91a8958 Detect and canonicalize identity tables 2018-04-11 mtklein skcms→307ec0f remove a layer of nesting in skcms_Curve 2018-04-10 robertphillips Fix alpha threshold image filter GPU implementation 2018-04-10 egdaniel Remove guard around getBackendTexture/RenderTarget calls 2018-04-11 robertphillips Revert "Fix handling of MaskFilter matrices" 2018-04-10 angle-skia-autoroll Roll third_party/externals/angle2/ 0ce016c1b..785b20b7a (7 commits) 2018-04-10 fmalita Fix handling of MaskFilter matrices 2018-04-10 robertphillips Get ViaDDL working with Vulkan 2018-04-10 brianosman skcms→e753c6d disable -Wdouble-promotion 2018-04-10 egdaniel Move GrBackendRenderTarget over to new system of getting backed infos 2018-04-10 liyuqian Remove unused field fBitmapBytes Created with: roll-dep src/third_party/skia BUG= chromium:824145 , chromium:821353 , chromium:821353 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I206b007db0efd69b539806f5ba806bb8d4956d6d Reviewed-on: https://chromium-review.googlesource.com/1008972 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550059} [modify] https://crrev.com/8ab03fe975c537e4daf31ef51c74553b5aba67ca/DEPS
,
Apr 12 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/31608c02c2533810587f5807c0c34f8ac19290b9 commit 31608c02c2533810587f5807c0c34f8ac19290b9 Author: Cary Clark <caryclark@skia.org> Date: Thu Apr 12 15:05:40 2018 another rect is path fix This addresses comment #17 of skbug.com/7792. The bug overshoots the end and exploits that the first point tracked by close isn't the first point in the rectangle. Fixing this slightly regresses the example in comment #14; before it was treated as a filled rect but now it is not; this conservative approach doesn't cause any other regressions. bug7792 in pathfill.cpp verifies that all paths in the bug draw correctly by comparing CPU and GPU. R=robertphillips@google.com Bug: 824145 , skia:7792 Change-Id: I55bea023d2ad7456c8c3ebd9d1df95fe34e0a0d4 Reviewed-on: https://skia-review.googlesource.com/120996 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/31608c02c2533810587f5807c0c34f8ac19290b9/tests/PathTest.cpp [modify] https://crrev.com/31608c02c2533810587f5807c0c34f8ac19290b9/gm/pathfill.cpp [modify] https://crrev.com/31608c02c2533810587f5807c0c34f8ac19290b9/src/core/SkPath.cpp
,
Apr 12 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/88ba9710b5e93a3a2e15e205f6979d245e76a127 commit 88ba9710b5e93a3a2e15e205f6979d245e76a127 Author: Cary Clark <caryclark@skia.org> Date: Thu Apr 12 20:45:32 2018 son of path is rect bug This variation tricks SkPath::isRect by exploiting that the implementation resets the point pointer to process the close verb, and using the reset pointer to walk over a series of points that don't move. In addition to fixing this, rename variables to make the line creation more obvious, since left, right, and friends, are not the left and right. R=robertphillips@google.com Bug: 824145 , skia:7792 Change-Id: If8ebbc3eedd270652670d6e111a5bc02e61f0eec Reviewed-on: https://skia-review.googlesource.com/121122 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@skia.org> [modify] https://crrev.com/88ba9710b5e93a3a2e15e205f6979d245e76a127/tests/PathTest.cpp [modify] https://crrev.com/88ba9710b5e93a3a2e15e205f6979d245e76a127/gm/pathfill.cpp [modify] https://crrev.com/88ba9710b5e93a3a2e15e205f6979d245e76a127/src/core/SkPath.cpp
,
Apr 13 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/d4228473a552dc2e683182c47a957977f53df581 commit d4228473a552dc2e683182c47a957977f53df581 Author: Cary Clark <caryclark@skia.org> Date: Fri Apr 13 14:01:32 2018 path is rect bug number nine This variation exploits a sequence which uses a zero length line to note that lines have been recorded, but no rectangle edge has been encountered. R=robertphillips@google.com Docs-Preview: https://skia.org/?cl=121282 Bug: 824145 , skia:7792 Change-Id: I652e9482b2867c3d7da30d5f5df2aecbfd0d716d Reviewed-on: https://skia-review.googlesource.com/121282 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@skia.org> [modify] https://crrev.com/d4228473a552dc2e683182c47a957977f53df581/tests/PathTest.cpp [modify] https://crrev.com/d4228473a552dc2e683182c47a957977f53df581/gm/pathfill.cpp [modify] https://crrev.com/d4228473a552dc2e683182c47a957977f53df581/src/core/SkPath.cpp
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb commit db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 13 20:04:30 2018 Roll src/third_party/skia/ c6c5eade8..21dfd8467 (29 commits) https://skia.googlesource.com/skia.git/+log/c6c5eade823a..21dfd846724a $ git log c6c5eade8..21dfd8467 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ ed8d5ec73..cc1293775 (1 commit) 2018-04-12 liyuqian Limit our IsBadForDAA for stroke width > 0 and <= 2 2018-04-12 csmartdalton ccpr: Actually blacklist ANGLE 2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 14f4817c4..ed8d5ec73 (8 commits) 2018-04-12 reed can't abort looper loop, as saveCount won't be balanced 2018-04-12 egdaniel Don't create lazy proxys if their width/height is greater than max tex size 2018-04-12 robertphillips Actually generate the gm images on the DDL1 bot 2018-04-12 caryclark son of path is rect bug 2018-04-12 ethannicholas workaround for buggy macOS GLSL shader compiler 2018-04-12 egdaniel Delete getRenderTargetHandle call on SkSurface. 2018-04-12 reed check for non-finite values output by clipper 2018-04-12 brianosman Fail fast when trying to make a texture that's too large 2018-04-12 djsollen Include shadow ops in the debugger. 2018-04-11 liyuqian Reland "Add private fIsBadForDAA bit to SkPath" 2018-04-12 reed add conservative bounds to raster tiling 2018-04-12 reed always clear the looper when we're unrolling it, to not confused devices 2018-04-11 robertphillips Disable CCPR and the small path renderer on DDL1 bot 2018-04-12 caryclark another rect is path fix 2018-04-11 robertphillips Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS 2018-04-11 csmartdalton Implement Sk2f Load2 2018-04-11 csmartdalton ccpr: Blacklist ANGLE again 2018-04-11 robertphillips Allow SkImage_Gpu to fail some requests in DDL mode 2018-04-11 cwallez update_meta_config: Use new LUCI optional GPU trybot on Windows 2018-04-11 csmartdalton Implement Sk4f min/max 2018-04-11 liyuqian Remove obsolete comment 2018-04-11 benjaminwagner Upgrade PixelC and NexusPlayer OS. 2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 2dadd1d08..14f4817c4 (2 commits) 2018-04-11 caryclark fix bm gm 2018-04-12 mtklein skcms→1654786 concat gamut transform matrices together Created with: roll-dep src/third_party/skia BUG= chromium:824145 , chromium:821353 ,chromium:818693,chromium:820245,chromium:820470, chromium:824145 ,chromium:815092 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ic83a9e3addd0c3593736a5bd03a4b4b2d37b7c51 Reviewed-on: https://chromium-review.googlesource.com/1011738 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Eric Boren <borenet@chromium.org> Cr-Commit-Position: refs/heads/master@{#550739} [modify] https://crrev.com/db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb/DEPS
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/625dceb10fd7d7a620af93a0f362e0f541cc0a23 commit 625dceb10fd7d7a620af93a0f362e0f541cc0a23 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 13 23:26:18 2018 Roll src/third_party/skia/ 21dfd8467..490aa59ce (13 commits) https://skia.googlesource.com/skia.git/+log/21dfd846724a..490aa59ce2e9 $ git log 21dfd8467..490aa59ce --date=short --no-merges --format='%ad %ae %s' 2018-04-13 reed rewrite iterator to make msvc happy 2018-04-13 brianosman Support downscaling to max texture size when making cross-context images 2018-04-13 borenet Add a MSVS bot to the CQ 2018-04-13 liyuqian Clone the xpos array in drawPosText 2018-04-13 ethannicholas added sk_LastFragColor 2018-04-13 reed Revert "add test for degenerate canvas dimension" 2018-04-13 reed add test for degenerate canvas dimension 2018-04-13 robertphillips Don't try to readback from the GPU for small blur sigmas 2017-12-20 herb Make a GM for checking blur bounds. 2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ cc1293775..983c429fa (1 commit) 2018-04-13 fmalita [skottie] Harden json string parsing 2018-04-13 caryclark path is rect bug number nine 2018-04-13 hcm Update Skia milestone to 68 Created with: roll-dep src/third_party/skia BUG= chromium:832838 , chromium:824145 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ie3362a821e3592adfd5e247ef6fdab0c9562e5d8 Reviewed-on: https://chromium-review.googlesource.com/1013048 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550812} [modify] https://crrev.com/625dceb10fd7d7a620af93a0f362e0f541cc0a23/DEPS
,
Apr 17 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/48c464a3c4fe12cb43b33666735cf3c26a038e66 commit 48c464a3c4fe12cb43b33666735cf3c26a038e66 Author: Cary Clark <caryclark@skia.org> Date: Tue Apr 17 11:46:53 2018 a more involved path is rect bug This is bug number ten in the series, and is the most interesting. It exploits that the code tracks corners 0, 2, and 3 but not corner 1. Changing the code to track all corners is the biggest so far, and while it (hopefully) simplifies things, the presence of new code may signify more bugs to come. R=robertphillips@google.com Bug: 824145 ,skia::7792 Change-Id: Ia18e4d80fbed06ae6d9c89dcb4c462c5610213cc Reviewed-on: https://skia-review.googlesource.com/121487 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@google.com> [modify] https://crrev.com/48c464a3c4fe12cb43b33666735cf3c26a038e66/tests/PathTest.cpp [modify] https://crrev.com/48c464a3c4fe12cb43b33666735cf3c26a038e66/gm/pathfill.cpp [modify] https://crrev.com/48c464a3c4fe12cb43b33666735cf3c26a038e66/src/core/SkPath.cpp
,
Apr 17 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/a7651567ca7e5462de993f1b23d681c6171bcccf commit a7651567ca7e5462de993f1b23d681c6171bcccf Author: Cary Clark <caryclark@skia.org> Date: Tue Apr 17 13:50:13 2018 yet another path is rect exploit This one accumulates the othershoot when all four sides have the same direction, and the final side when closed should cause the overshoot to be ignored. Docs-Preview: https://skia.org/?cl=121787 Bug: 824145 , skia:7792 Change-Id: I71ea0fcdd0f03a4fcac224b57220c65c321112f6 Reviewed-on: https://skia-review.googlesource.com/121787 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/a7651567ca7e5462de993f1b23d681c6171bcccf/tests/PathTest.cpp [modify] https://crrev.com/a7651567ca7e5462de993f1b23d681c6171bcccf/gm/pathfill.cpp [modify] https://crrev.com/a7651567ca7e5462de993f1b23d681c6171bcccf/src/core/SkPath.cpp
,
Apr 17 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/1cd6098d52a531451f194437861cd7a548f825a7 commit 1cd6098d52a531451f194437861cd7a548f825a7 Author: Cary Clark <caryclark@skia.org> Date: Tue Apr 17 16:42:04 2018 path is rect bug number twelve Exposes that final close along a diagonal need not include a close verb if the subsequent verb is move; so we have to check for a diagonal then. The later check for diagonal included a comment that it may not be needed which does appear to be the case. R=robertphillips@google.com Bug: 824145 , skia:7792 Change-Id: I17a9414e8b3e69b82c2eda28195696eae4e3d513 Reviewed-on: https://skia-review.googlesource.com/121801 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/1cd6098d52a531451f194437861cd7a548f825a7/tests/PathTest.cpp [modify] https://crrev.com/1cd6098d52a531451f194437861cd7a548f825a7/gm/pathfill.cpp [modify] https://crrev.com/1cd6098d52a531451f194437861cd7a548f825a7/src/core/SkPath.cpp
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb commit db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 13 20:04:30 2018 Roll src/third_party/skia/ c6c5eade8..21dfd8467 (29 commits) https://skia.googlesource.com/skia.git/+log/c6c5eade823a..21dfd846724a $ git log c6c5eade8..21dfd8467 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ ed8d5ec73..cc1293775 (1 commit) 2018-04-12 liyuqian Limit our IsBadForDAA for stroke width > 0 and <= 2 2018-04-12 csmartdalton ccpr: Actually blacklist ANGLE 2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 14f4817c4..ed8d5ec73 (8 commits) 2018-04-12 reed can't abort looper loop, as saveCount won't be balanced 2018-04-12 egdaniel Don't create lazy proxys if their width/height is greater than max tex size 2018-04-12 robertphillips Actually generate the gm images on the DDL1 bot 2018-04-12 caryclark son of path is rect bug 2018-04-12 ethannicholas workaround for buggy macOS GLSL shader compiler 2018-04-12 egdaniel Delete getRenderTargetHandle call on SkSurface. 2018-04-12 reed check for non-finite values output by clipper 2018-04-12 brianosman Fail fast when trying to make a texture that's too large 2018-04-12 djsollen Include shadow ops in the debugger. 2018-04-11 liyuqian Reland "Add private fIsBadForDAA bit to SkPath" 2018-04-12 reed add conservative bounds to raster tiling 2018-04-12 reed always clear the looper when we're unrolling it, to not confused devices 2018-04-11 robertphillips Disable CCPR and the small path renderer on DDL1 bot 2018-04-12 caryclark another rect is path fix 2018-04-11 robertphillips Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS 2018-04-11 csmartdalton Implement Sk2f Load2 2018-04-11 csmartdalton ccpr: Blacklist ANGLE again 2018-04-11 robertphillips Allow SkImage_Gpu to fail some requests in DDL mode 2018-04-11 cwallez update_meta_config: Use new LUCI optional GPU trybot on Windows 2018-04-11 csmartdalton Implement Sk4f min/max 2018-04-11 liyuqian Remove obsolete comment 2018-04-11 benjaminwagner Upgrade PixelC and NexusPlayer OS. 2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 2dadd1d08..14f4817c4 (2 commits) 2018-04-11 caryclark fix bm gm 2018-04-12 mtklein skcms→1654786 concat gamut transform matrices together Created with: roll-dep src/third_party/skia BUG= chromium:824145 , chromium:821353 ,chromium:818693,chromium:820245,chromium:820470, chromium:824145 ,chromium:815092 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ic83a9e3addd0c3593736a5bd03a4b4b2d37b7c51 Reviewed-on: https://chromium-review.googlesource.com/1011738 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Eric Boren <borenet@chromium.org> Cr-Commit-Position: refs/heads/master@{#550739} [modify] https://crrev.com/db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb/DEPS
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/625dceb10fd7d7a620af93a0f362e0f541cc0a23 commit 625dceb10fd7d7a620af93a0f362e0f541cc0a23 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 13 23:26:18 2018 Roll src/third_party/skia/ 21dfd8467..490aa59ce (13 commits) https://skia.googlesource.com/skia.git/+log/21dfd846724a..490aa59ce2e9 $ git log 21dfd8467..490aa59ce --date=short --no-merges --format='%ad %ae %s' 2018-04-13 reed rewrite iterator to make msvc happy 2018-04-13 brianosman Support downscaling to max texture size when making cross-context images 2018-04-13 borenet Add a MSVS bot to the CQ 2018-04-13 liyuqian Clone the xpos array in drawPosText 2018-04-13 ethannicholas added sk_LastFragColor 2018-04-13 reed Revert "add test for degenerate canvas dimension" 2018-04-13 reed add test for degenerate canvas dimension 2018-04-13 robertphillips Don't try to readback from the GPU for small blur sigmas 2017-12-20 herb Make a GM for checking blur bounds. 2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ cc1293775..983c429fa (1 commit) 2018-04-13 fmalita [skottie] Harden json string parsing 2018-04-13 caryclark path is rect bug number nine 2018-04-13 hcm Update Skia milestone to 68 Created with: roll-dep src/third_party/skia BUG= chromium:832838 , chromium:824145 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ie3362a821e3592adfd5e247ef6fdab0c9562e5d8 Reviewed-on: https://chromium-review.googlesource.com/1013048 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550812} [modify] https://crrev.com/625dceb10fd7d7a620af93a0f362e0f541cc0a23/DEPS
,
Apr 17 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/4eb6f7a698e80ce0faa7e3700e6cfd0d89f99089 commit 4eb6f7a698e80ce0faa7e3700e6cfd0d89f99089 Author: Cary Clark <caryclark@skia.org> Date: Tue Apr 17 18:15:34 2018 path is rect diag test is required Removed a test that appeared to go uncalled; Ivan to the rescue, with a test case proving that it is required. R=robertphillips@google.com Bug: 824145 , skia:7792 Change-Id: I7df9688072bd36b7597673148e3fe5dbbf82f5a7 Reviewed-on: https://skia-review.googlesource.com/121883 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/4eb6f7a698e80ce0faa7e3700e6cfd0d89f99089/tests/PathTest.cpp [modify] https://crrev.com/4eb6f7a698e80ce0faa7e3700e6cfd0d89f99089/gm/pathfill.cpp [modify] https://crrev.com/4eb6f7a698e80ce0faa7e3700e6cfd0d89f99089/src/core/SkPath.cpp
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25109f9bb975178a07428cd7bc0ddf26b5c8d2b4 commit 25109f9bb975178a07428cd7bc0ddf26b5c8d2b4 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Apr 17 23:45:46 2018 Roll src/third_party/skia/ eedecc604..c186e17a6 (28 commits) https://skia.googlesource.com/skia.git/+log/eedecc6046b2..c186e17a6b78 $ git log eedecc604..c186e17a6 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 robertphillips Add handling to ViaDDL for images that are too large to be uploaded in one go 2018-04-17 herb Move node information to SkStrikeCache 2018-04-17 bungeman IWYU for some more test files starting with 'C'. 2018-04-17 reed detect if we made an infinite rect 2018-04-17 borenet [infra] Support recursive configs in builder_name_schema 2018-04-16 egdaniel No long require copy as draw for vulkan wrapped resources. 2018-04-17 caryclark path is rect diag test is required 2018-04-17 mtklein SkStrikeDifferences::operator() -> add() 2018-04-17 reed avoid overflow by using tmp 64bits 2018-04-17 brianosman Move external texture extension logic into SkSL 2018-04-17 benjaminwagner [infra] Add service account override in gen_tasks.go. 2018-04-17 caryclark path is rect bug number twelve 2018-04-17 bungeman Add paint flags to viewer GUI. 2018-04-17 mtklein skcms→3be11ac refactor a bit 2018-04-17 liyuqian Revert "Fix the fat rect bug in the threaded backend" 2018-04-17 reed only recheck fNeedsTiling if we computed fSrcBounds 2018-04-17 brianosman Add SkColorSpace::Make, taking an skcms_ICCProfile 2018-04-16 mtklein Reland "low-hanging bilerp_clamp_8888 wins" 2018-04-17 mtklein skcms→38f22d2 name types in skcms.h 2018-04-17 herb Reorganize strike cache and glyph cache code 2018-04-16 liyuqian Fix the fat rect bug in the threaded backend 2018-04-17 caryclark yet another path is rect exploit 2018-04-17 angle-skia-autoroll Roll third_party/externals/angle2/ 08b9e046c..86de76b69 (1 commit) 2018-04-16 halcanary SkColorSetARGB in constants 2018-04-16 caryclark a more involved path is rect bug 2018-04-16 egdaniel Update our config fallback switch in GrContext. 2018-04-17 borenet Revert "Reland "[infra] Run recipes through Kitchen"" 2018-04-16 borenet Reland "[infra] Run recipes through Kitchen" Created with: roll-dep src/third_party/skia BUG= chromium:824145 , chromium:824145 , chromium:824145 , chromium:824145 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I1489c857f9c6e71b8e55bd7deaa3230a33759926 Reviewed-on: https://chromium-review.googlesource.com/1015796 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551524} [modify] https://crrev.com/25109f9bb975178a07428cd7bc0ddf26b5c8d2b4/DEPS
,
Apr 18 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/b120e9291a7d43347ebce89de522a15771cd9dea commit b120e9291a7d43347ebce89de522a15771cd9dea Author: Cary Clark <caryclark@skia.org> Date: Wed Apr 18 17:46:03 2018 fix path is rect flaw exposed by gold One of the path is rect bug fixes changed the behavior of zero-length strokes which showed up as a change in Gold. The bug is if a rect is defined by a series of colinear movetos, the bounds did not work out if the rect started and stopped in the middle of a side. R=robertphillips@google.com Bug: 824145 , skia:7792 Change-Id: I226545efeda03dedd928eebc120d2508b428fef0 Reviewed-on: https://skia-review.googlesource.com/122002 Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@skia.org> [modify] https://crrev.com/b120e9291a7d43347ebce89de522a15771cd9dea/tests/PathTest.cpp [modify] https://crrev.com/b120e9291a7d43347ebce89de522a15771cd9dea/gm/pathfill.cpp [modify] https://crrev.com/b120e9291a7d43347ebce89de522a15771cd9dea/src/core/SkPath.cpp
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e0589fc554c9a1575046d3a751c7e7bc6d38440 commit 1e0589fc554c9a1575046d3a751c7e7bc6d38440 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 19 00:10:45 2018 Roll src/third_party/skia/ 366fc2475..4c32956b1 (11 commits) https://skia.googlesource.com/skia.git/+log/366fc2475261..4c32956b1fee $ git log 366fc2475..4c32956b1 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 bungeman DFT to draw A8 instead of incorrect vertical lcd. 2018-04-18 csmartdalton ccpr: Implement conics 2018-04-18 csmartdalton Always call endFlush on opLists that might survive a flush 2018-04-18 fmalita Convert A8 D32 mask blitters to Sk4px 2018-04-18 liyuqian Reland "Fix the fat rect bug in the threaded backend" 2018-04-18 halcanary SkQP: speed up tools/skqp/make_apk_list\ 2018-04-18 brianosman Support all destination profiles in SkColorSpaceXform_skcms 2018-04-17 brianosman With ES3, enable both ES2 and ES3 external image extensions 2018-04-18 caryclark fix path is rect flaw exposed by gold 2018-04-18 mtklein skcms→b4e167a stricter TF13 matching 2018-04-18 mtklein skcms→589b15b add skcms_EnsureUsableAsDestination Created with: roll-dep src/third_party/skia BUG= chromium:824145 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I150186c8af37f82ded9aeb5d6852b4dd10d12efc Reviewed-on: https://chromium-review.googlesource.com/1017980 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551889} [modify] https://crrev.com/1e0589fc554c9a1575046d3a751c7e7bc6d38440/DEPS
,
Apr 19 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/dbc59ba23b5cb70cdf77cfdb6cbe372223a17832 commit dbc59ba23b5cb70cdf77cfdb6cbe372223a17832 Author: Cary Clark <caryclark@skia.org> Date: Thu Apr 19 12:11:34 2018 path is rect track corners This was triggered by an exploit that started the first edge well outside the final rectangle, causing the captured to exceed the correct result. Ivan observes that we really only want the first and third corners to compute the bounds, so remove the tracking code that looks for a valid range of points, and record the corners instead. R=robertphillips@google.com Bug: 824145 , skia:7792 Change-Id: If228573d0f05c7158dba8142c144d13834e691ec Reviewed-on: https://skia-review.googlesource.com/122081 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Auto-Submit: Cary Clark <caryclark@skia.org> [modify] https://crrev.com/dbc59ba23b5cb70cdf77cfdb6cbe372223a17832/tests/PathTest.cpp [modify] https://crrev.com/dbc59ba23b5cb70cdf77cfdb6cbe372223a17832/gm/pathfill.cpp [modify] https://crrev.com/dbc59ba23b5cb70cdf77cfdb6cbe372223a17832/src/core/SkPath.cpp
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbf12bb49278f24340aaf765c3595d996dfdf5b8 commit fbf12bb49278f24340aaf765c3595d996dfdf5b8 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 19 13:40:00 2018 Roll src/third_party/skia/ 4c32956b1..2ae45ae83 (9 commits) https://skia.googlesource.com/skia.git/+log/4c32956b1fee..2ae45ae83a57 $ git log 4c32956b1..2ae45ae83 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 scroggo Revert "Add stub gpu workaround generators" 2018-04-19 caryclark path is rect track corners 2018-04-17 borenet Reland "[infra] Run recipes through Kitchen" 2018-04-19 angle-skia-autoroll Roll third_party/externals/angle2/ aaa19de06..eeec3b14c (1 commit) 2018-04-18 angle-skia-autoroll Roll third_party/externals/angle2/ 5804dc8ea..aaa19de06 (9 commits) 2018-04-18 enne Add stub gpu workaround generators 2018-04-18 herb Move strike cache Find*() to strike cache 2018-04-18 liyuqian Remove SK_SUPPORT_LEGACY_PATH_DAA_BIT 2018-04-18 fmalita Prevent unnecessary/unbounded growth of SkTDynamicHash capacity Created with: roll-dep src/third_party/skia BUG= chromium:829614 , chromium:824145 , chromium:829614 , chromium:832482 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I6d92732f2ff872d7b5c1df456c66cc54a4615abc Reviewed-on: https://chromium-review.googlesource.com/1019381 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551999} [modify] https://crrev.com/fbf12bb49278f24340aaf765c3595d996dfdf5b8/DEPS
,
Apr 23 2018
,
Apr 24 2018
Issue 829605 has been merged into this issue. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by susan.boorgula@chromium.org
, Mar 21 2018