New issue
Advanced search Search tips

Issue 824141 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

M67 Cronet crashes

Project Member Reported by pauljensen@chromium.org, Mar 21 2018

Issue description


pid: 4665, tid: 4832, name: TaskSchedulerFo
signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------

Stack Trace:
  RELADDR   FUNCTION                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         FILE:LINE
  0029086f  base::debug::StackTrace::StackTrace()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            /b/build/slave/cronet-x86-debug/build/src/base/debug/stack_trace.cc:199:28
  002aca3c  logging::LogMessage::~LogMessage()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               /b/build/slave/cronet-x86-debug/build/src/base/logging.cc:594:29
  00000ac4  <UNKNOWN>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        /home/pauljensen/chrome/src/[vdso:b2149000]
  0001edf8  <UNKNOWN>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        /system/lib/libc.so
  0001f073  <UNKNOWN>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        /system/lib/libc.so
  v------>  base::debug::(anonymous namespace)::DebugBreak()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 /b/build/slave/cronet-x86-debug/build/src/base/debug/debugger_posix.cc:228:5
  002906d3  base::debug::BreakDebugger()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     /b/build/slave/cronet-x86-debug/build/src/base/debug/debugger_posix.cc:258:0
  002acd8e  logging::LogMessage::~LogMessage()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               /b/build/slave/cronet-x86-debug/build/src/base/logging.cc:855:7
  0027db53  base::android::ConvertJavaStringToUTF8(_JNIEnv*, _jstring*, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >*)                                                                                                                                                                                                                                                                                                                                                                                                                                     /b/build/slave/cronet-x86-debug/build/src/base/android/jni_string.cc:27:3
  0027b70f  base::android::AppendJavaStringArrayToStringVector(_JNIEnv*, _jobjectArray*, std::__ndk1::vector<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, std::__ndk1::allocator<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > > >*)                                                                                                                                                                                                                                                                     /b/build/slave/cronet-x86-debug/build/src/base/android/jni_array.cc:190:5
  002769a8  base::android::BuildInfoSingletonTraits::New()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   /b/build/slave/cronet-x86-debug/build/src/base/android/build_info.cc:41:5
  0027425d  base::AndroidHardwareBufferCompat* base::subtle::GetOrCreateLazyPointer<base::AndroidHardwareBufferCompat>(int*, base::AndroidHardwareBufferCompat* (*)(void*), void*, void (*)(void*), void*)                                                                                                                                                                                                                                                                                                                                                                                                   /b/build/slave/cronet-x86-debug/build/src/base/lazy_instance_helpers.h:83:48
  002767ea  base::Singleton<base::android::BuildInfo, base::android::BuildInfoSingletonTraits, base::android::BuildInfo>::get()                                                                                                                                                                                                                                                                                                                                                                                                                                                                              /b/build/slave/cronet-x86-debug/build/src/base/memory/singleton.h:236:12
  v------>  net::internal::(anonymous namespace)::ReadDnsConfig(net::DnsConfig*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             /b/build/slave/cronet-x86-debug/build/src/net/dns/dns_config_service_posix.cc:196:7
  0041e3a1  net::internal::DnsConfigServicePosix::ConfigReader::DoWork()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     /b/build/slave/cronet-x86-debug/build/src/net/dns/dns_config_service_posix.cc:323:0
  003e8edf  void base::internal::FunctorTraits<void (disk_cache::BackendIO::*)(), void>::Invoke<scoped_refptr<disk_cache::BackendIO> const&>(void (disk_cache::BackendIO::*)(), scoped_refptr<disk_cache::BackendIO> const&)                                                                                                                                                                                                                                                                                                                                                                                 /b/build/slave/cronet-x86-debug/build/src/base/bind_internal.h:447:12
  003e8e9e  void base::internal::InvokeHelper<false, void>::MakeItSo<void (disk_cache::BackendIO::* const&)(), scoped_refptr<disk_cache::BackendIO> const&>(void (disk_cache::BackendIO::* const&)(), scoped_refptr<disk_cache::BackendIO> const&)                                                                                                                                                                                                                                                                                                                                                           /b/build/slave/cronet-x86-debug/build/src/base/bind_internal.h:530:12
  v------>  void base::internal::Invoker<base::internal::BindState<void (disk_cache::BackendIO::*)(), scoped_refptr<disk_cache::BackendIO> >, void ()>::RunImpl<void (disk_cache::BackendIO::* const&)(), std::__ndk1::tuple<scoped_refptr<disk_cache::BackendIO> > const&, 0u>(void (disk_cache::BackendIO::* const&)(), std::__ndk1::tuple<scoped_refptr<disk_cache::BackendIO> > const&, std::__ndk1::integer_sequence<unsigned int, 0u>)                                                                                                                                                                 /b/build/slave/cronet-x86-debug/build/src/base/bind_internal.h:604:12
  003e8e61  base::internal::Invoker<base::internal::BindState<void (disk_cache::BackendIO::*)(), scoped_refptr<disk_cache::BackendIO> >, void ()>::Run(base::internal::BindStateBase*)                                                                                                                                                                                                                                                                                                                                                                                                                       /b/build/slave/cronet-x86-debug/build/src/base/bind_internal.h:586:0
  002834fe  base::OnceCallback<void ()>::Run() &&                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            /b/build/slave/cronet-x86-debug/build/src/base/callback.h:95:12
  0030896c  base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        /b/build/slave/cronet-x86-debug/build/src/base/threading/post_task_and_reply_impl.cc:45:22
  v------>  void base::internal::FunctorTraits<void (base::(anonymous namespace)::BarrierInfo::*)(), void>::Invoke<base::(anonymous namespace)::BarrierInfo*>(void (base::(anonymous namespace)::BarrierInfo::*)(), base::(anonymous namespace)::BarrierInfo*&&)                                                                                                                                                                                                                                                                                                                                             /b/build/slave/cronet-x86-debug/build/src/base/bind_internal.h:447:12
  v------>  void base::internal::InvokeHelper<false, void>::MakeItSo<void (base::(anonymous namespace)::BarrierInfo::* const&)(), base::(anonymous namespace)::BarrierInfo*>(void (base::(anonymous namespace)::BarrierInfo::* const&)(), base::(anonymous namespace)::BarrierInfo*&&)                                                                                                                                                                                                                                                                                                                       /b/build/slave/cronet-x86-debug/build/src/base/bind_internal.h:530:0
  v------>  void base::internal::Invoker<base::internal::BindState<void (base::(anonymous namespace)::BarrierInfo::*)(), base::internal::OwnedWrapper<base::(anonymous namespace)::BarrierInfo> >, void ()>::RunImpl<void (base::(anonymous namespace)::BarrierInfo::* const&)(), std::__ndk1::tuple<base::internal::OwnedWrapper<base::(anonymous namespace)::BarrierInfo> > const&, 0u>(void (base::(anonymous namespace)::BarrierInfo::* const&)(), std::__ndk1::tuple<base::internal::OwnedWrapper<base::(anonymous namespace)::BarrierInfo> > const&, std::__ndk1::integer_sequence<unsigned int, 0u>)  /b/build/slave/cronet-x86-debug/build/src/base/bind_internal.h:604:0
  002835e7  base::internal::Invoker<base::internal::BindState<void (base::(anonymous namespace)::BarrierInfo::*)(), base::internal::OwnedWrapper<base::(anonymous namespace)::BarrierInfo> >, void ()>::Run(base::internal::BindStateBase*)                                                                                                                                                                                                                                                                                                                                                                  /b/build/slave/cronet-x86-debug/build/src/base/bind_internal.h:586:0
  002834fe  base::OnceCallback<void ()>::Run() &&                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            /b/build/slave/cronet-x86-debug/build/src/base/callback.h:95:12
 
Components: -Internals>Network>DNS
Looks like this is crashing:
base::android::BuildInfo::GetInstance()->sdk_int()
Cc: agrieve@chromium.org tobiasjs@chromium.org
Someone narrowed it down to between 67.0.3363.3 and 67.0.3365.0.
Looks caused by r541114 or r541554
Abort message: '[0320/120932.989451:FATAL:jni_string.cc(27)] Check failed: str.
Looks like BuildInfo had a null guard for versionName, but I missed adding one for my change there. I'll send you a CL
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb9bc5965437ce539163205e8d8ab763fde1f5c

commit 3cb9bc5965437ce539163205e8d8ab763fde1f5c
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Mar 21 15:37:31 2018

Android: Guard against null versionName in BuildInfo

This regressed in be35cd67008fdd35bd56f83baab8abce07543332

Bug:  824141 
Change-Id: I7975bc8dffbfafeec7f0a50bad4d75dfeefff0ee
Reviewed-on: https://chromium-review.googlesource.com/973383
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544711}
[modify] https://crrev.com/3cb9bc5965437ce539163205e8d8ab763fde1f5c/base/android/java/src/org/chromium/base/BuildInfo.java

Status: Fixed (was: Untriaged)

Sign in to add a comment