New issue
Advanced search Search tips

Issue 824133 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Start-up race on captureVisibleTab

Reported by ana...@yandex-team.ru, Mar 21 2018

Issue description

Sometimes api call chrome.tabs.captureVisibleTab can throw exception or return stale data. The reason of this in the start-up race. We can trying capture while there was no first painting and surface wasn't activated. 

This issue is a reason of flakiness some tests, for example ExtensionApiCaptureTests - CaptureVisibleTabPng, CaptureVisibleTabJpeg, CaptureVisibleTabRace, CaptureVisibleFile and maybe some another. The condition tab.status == 'complete' is not enough for detect this situation. Capture fails when IsSurfaceAvailableForCopy return false. It's happening because there wasn't a call DelegatedFrameHost::OnFirstSurfaceActivation.

The decision of this problem could be: for CopyFromSurface() to hold onto the copy request until the Surface is created.

Related CL and conversation: https://chromium-review.googlesource.com/c/chromium/src/+/968483

Crbug components: Internals>Services>Viz, Internals>Media>ScreenCapture

 
Components: Platform>Extensions>API Internals>Media>ScreenCapture
Owner: m...@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 3 by m...@chromium.org, Apr 11 2018

Now that a recent change has landed (https://chromium-review.googlesource.com/c/chromium/src/+/978870), the start-up race might be gone now. Will need testing to confirm...
Status: Fixed (was: Assigned)

Sign in to add a comment