New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824115 link

Starred by 8 users

Issue metadata

Status: Duplicate
Merged: issue 848124
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

FIles app won't open files without extension

Reported by jase...@gmail.com, Mar 21 2018

Issue description

Chrome Version       : 64.0.3282.190
OS Version: 10176.76.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari: N/A
    Firefox: N/A
    IE/Edge: N/A

What steps will reproduce the problem?
1. Open Files app in Chrome OS and remove file extension from an image
2. The app will show correct file type when "show info", even show the thumbnail, but it won't open in default app Gallery as it won't recognise the file without the extension.
3.

What is the expected result?

The image/file should open regardless of the file extension if the OS can read metadata and show correct file type in info.

What happens instead of that?

Files won't open without "proper" extension. The app is offering options to use other apps to open files that are not really appropriate.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 10176.76.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.190 Safari/537.36



 
Screenshot 2018-03-18 at 16.50.22.png
805 KB View Download
This is being discussed in the Pixelbook Help Forum, but it impacts all ChromeOS devices
https://productforums.google.com/forum/#!topic/pixelbook/XTjXmzT6e2w

#CBC-RS/TC-watchlist

Components: Platform>Apps>FileManager
Cc: oka@chromium.org mcirimele@chromium.org weifangsun@chromium.org
 Issue 772601  has been merged into this issue.
Cc: hirono@chromium.org fukino@chromium.org
 Issue 772473  has been merged into this issue.
Cc: yamaguchi@chromium.org smckay@chromium.org nya@chromium.org
 Issue 686649  has been merged into this issue.
Labels: CrOSFilesFeature-FileIntents M-69 UpdateTestCasesOnFix CrOSFilesFeature-QuickView
Status: Untriaged (was: Unconfirmed)
Summary: FIles app won't open files without extension (was: FIles app won't open files correctly )
Files app daily triage: I can confirm I can reproduce this issue.

1. I created a new image on my local Download folder (downloaded something from web).
2. I renamed the image (Ctrl+Enter) and removed the extension (.jpg).

The image immediately lost the thumbnail (since I was on thumbnail view) and opens on the default app (Google Keep).

If image inside Google Drive, it doesn't lose its thumbnail.

My Chrome version is 64.0.3282.190.

I also tried on my dev env Chrome version 67.0.3376.0, with same results.
-----------

Potential fix suggested on  crbug.com/772601 :
Utilize content sniffing implemented in https://codereview.chromium.org/224883008

Related bug/FR:  crbug.com/772601  - Quick view: show extension-less files properly

Priority 3 seems appropriate since there is a workaround available (to add the extension to the file).
-------------

This needs to be fixed on:
1. Thumbnail.
2. Open/Open with.
3. Quick View.
4. Gallery/Audio Player/Video Player.


The workaround is not great though - what if the user has no idea what the extension should be?

Comment 8 by jase...@gmail.com, Mar 23 2018

Exactly, and one of the concerns is that a file can be downloaded from the internet that could execute malicious code or run a script that could do some damage to your data, all based on the assumption that certain apps open bsed on the extension alone. It seems like the Google Drive file manager is a lot smarter than Files application.
This is not issue in individual applications, but due to the restriction of the filesystem and metadata provider.

Files from some external providers (like Google Drive) has MIME type attached by them, but doesn't exist in the local file system.
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider.js?q=contentMimeType&sq=package:chromium&l=1
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js?q=contentMimeType&sq=package:chromium&l=76

There's a logic to sniff the file type by reading first part of the file content, but seems it's not propagated (by|to) the metadata provider.
https://cs.chromium.org/chromium/src/extensions/browser/api/file_handlers/mime_util.cc?type=cs&sq=package:chromium&l=126
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Files app doesn't currently support unknown file types; this is a known area we can improve.

Comment 11 by sashab@google.com, May 24 2018

Labels: -M-69 -CrOSFilesFeature-QuickView
Labels: Hotlist-ConOps-CrOS
(Bulk Edit) Adding the new conops Chrome OS hotlist to all open issues with the "#CBC-RS/TC-watchlist" tag, our former tracking tag.
Owner: adanilo@chromium.org
Status: Assigned (was: Available)
Looks like there are some dupes/similar bugs - i'll let you collapse them as appropriate.
Mergedinto: 848124
Status: Duplicate (was: Assigned)

Sign in to add a comment