New issue
Advanced search Search tips

Issue 824098 link

Starred by 1 user
Status: Fixed
Owner:
clemensh@chromium.org
Closed: Mar 2018
Cc:
machenb...@chromium.org
clemensh@chromium.org
adamk@chromium.org
titzer@chromium.org
dschuff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue v8:6600



Sign in to add a comment

Add foozzie config for Liftoff

Project Member Reported by clemensh@chromium.org, Mar 21 2018 
We already had a few miscompilations in Liftoff which did not lead to crashes, but produced wrong output. It would be nice to let Foozzie catch some of those.

Is adding a foozzie config as easy as this, or are additional steps needed?

--- a/tools/clusterfuzz/v8_foozzie.py
+++ b/tools/clusterfuzz/v8_foozzie.py
@@ -56,6 +56,9 @@ CONFIGS = dict(
     '--no-lazy-inner-functions',
     '--suppress-asm-messages',
   ],
+  liftoff=[
+    '--liftoff',
+  ],
   slow_path=[
     '--force-slow-path',
     '--suppress-asm-messages',

Comment 1 by machenb...@chromium.org, Mar 21 2018

Owner: clemensh@chromium.org
Status: Assigned (was: Available)
That and a percentage here:
https://cs.chromium.org/chromium/src/v8/tools/clusterfuzz/v8_fuzz_config.py?l=10

Please make sure it adds up to 100. You can use 5% and subtract it from ignition_turbo part.

Note, we usually use ignition as baseline for everything to have more coverage. But as a result, also non-liftoff bugs might be detected in the experiment fraction.

Comment 2 by clemensh@chromium.org, Mar 21 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/49f23ce6425252a589f0e756be70d2d1224b70c2

commit 49f23ce6425252a589f0e756be70d2d1224b70c2
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Wed Mar 21 12:56:18 2018

[foozzie] Add Liftoff testing

This adds 5% testing of 'ignition' vs 'liftoff', which tests Turbofan vs
Liftoff for wasm code, and tests Ignition vs Turbofan for javascript
code.
It also adds 3% testing of 'liftoff' (x64) vs 'liftoff' (ia32), which
does standard x64 vs ia32 testing for javascript code.

R=machenbach@chromium.org

Bug:  chromium:824098 , v8:6600
Change-Id: I6a6afae0300efc33f3535541a11695a7bb32dcc5
Reviewed-on: https://chromium-review.googlesource.com/973161
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52111}
[modify] https://crrev.com/49f23ce6425252a589f0e756be70d2d1224b70c2/tools/clusterfuzz/v8_foozzie.py
[modify] https://crrev.com/49f23ce6425252a589f0e756be70d2d1224b70c2/tools/clusterfuzz/v8_foozzie_test.py
[modify] https://crrev.com/49f23ce6425252a589f0e756be70d2d1224b70c2/tools/clusterfuzz/v8_fuzz_config.py

Comment 4 by clemensh@chromium.org, Mar 21 2018

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/605f94b70077ab0c8a4d79ffbb33686883157932

commit 605f94b70077ab0c8a4d79ffbb33686883157932
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Jul 19 09:51:06 2018

[foozzie] Update existing configs for liftoff

Instead of having a separate liftoff config, which is tested against
the default (which currently means tier-up from liftoff to turbofan),
just choose reasonable liftoff configs for the existing configs.
'ignition' now implies pure liftoff execution.
'ignition_turbo_opt' always compiles with turbofan.
Other configs use the default (tier up).

R=machenbach@chromium.org

Bug:  chromium:824098 , v8:6600
Change-Id: I92c008fc1b1fa54d3161fb5695a095127d6ac263
Reviewed-on: https://chromium-review.googlesource.com/1141731
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54548}
[modify] https://crrev.com/605f94b70077ab0c8a4d79ffbb33686883157932/tools/clusterfuzz/testdata/failure_output.txt
[modify] https://crrev.com/605f94b70077ab0c8a4d79ffbb33686883157932/tools/clusterfuzz/v8_foozzie.py
[modify] https://crrev.com/605f94b70077ab0c8a4d79ffbb33686883157932/tools/clusterfuzz/v8_foozzie_test.py
[modify] https://crrev.com/605f94b70077ab0c8a4d79ffbb33686883157932/tools/clusterfuzz/v8_fuzz_config.py
►

Sign in to add a comment